From owner-freebsd-fs@FreeBSD.ORG Mon Jul 2 12:12:30 2012 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 60A1D106566B; Mon, 2 Jul 2012 12:12:30 +0000 (UTC) (envelope-from markus.gebert@hostpoint.ch) Received: from mail.adm.hostpoint.ch (mail.adm.hostpoint.ch [IPv6:2a00:d70:0:a::e0]) by mx1.freebsd.org (Postfix) with ESMTP id E7F1C8FC12; Mon, 2 Jul 2012 12:12:29 +0000 (UTC) Received: from [2001:1620:2013:1:7163:2c2b:3e7f:1ce9] (port=49496) by mail.adm.hostpoint.ch with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69 (FreeBSD)) (envelope-from ) id 1SlfUS-0000ZI-Lq; Mon, 02 Jul 2012 14:12:28 +0200 Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=iso-8859-1 From: Markus Gebert In-Reply-To: <0EF22D00-1CDB-44DA-BF3C-3AC672072C05@hostpoint.ch> Date: Mon, 2 Jul 2012 14:12:26 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201206251443.41768.jhb@freebsd.org> <201206270810.28589.jhb@freebsd.org> <0EF22D00-1CDB-44DA-BF3C-3AC672072C05@hostpoint.ch> To: John Baldwin X-Mailer: Apple Mail (2.1278) Cc: fs@freebsd.org Subject: Re: [PATCH] Simple ARC stats in top X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 12:12:30 -0000 Hi John On 27.06.2012, at 17:49, Markus Gebert wrote: > On 27.06.2012, at 14:10, John Baldwin wrote: >=20 >> Hmmm, my patch is relative to a top that has -P backported and I = can't=20 >> reproduce this, the ARC lines moves around properly if 'P' is toggled >> at runtime as well for me. Did you have any conflicts in your patch >> that you had to resolve by hand? >=20 > No, I did not merge anything by hand. But what I did, and that = probably was the cause, is only buildworld with NO_CLEAN=3D1 to save = time and just rebuild top. Now that I've done a full buildworld, the = probem seems to be gone. I'll test more and step up, if it happens = again, but consider this solved for now. Sorry for the noise. The problem is back. I don't know why I thought it was gone last week, = maybe I looked at the wrong terminal or something. Anyway, I tried again today, and I can reproduce this not only on 8.3 = but also on 9.0. To rule out a problem with iTerm I also tried OS X = Terminal and Gnome Terminal on Ubuntu. The terminal does not seem to = matter at all. This sample output is from a patched top (run with -S -P) on a 9.0 = server connected to via ssh: ---- last pid: 92857; load averages: 0.01, 0.01, 0.03 up 4+13:49:12 = 13:22:17 53 processes: 2 running, 50 sleeping, 1 waiting CPU 0: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle CPU 171 0.0% user, 50.0% nice, 0.0% system04 0.0% inter19pt, 100% idle CPU 2: 0.0% user, 020% nice10 0.0MFU, 1296K 0.0n, 42M Header 1006M = Other CPU 3: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle Mem: 66M Active, 154M Inact, 3174M Wired, 3152K Cache, 525M Free ARC: 2503M Total, 1191M MRU, 1003M MFU, 1680K Anon, 42M Header, 266M = Other Swap: 8192M Total, 11M Used, 8181M Free ---- After starting top, the first display is always correct. But as soon as = ARC values change, the new ones get written to a wrong line, in this = case CPU1 or CPU2. And the numbers on the ARC line don't seem to get = updated anymore. If I SHIFT-P twice, the display refreshes just fine, = but as soon as there are changes for the ARC values, things start to get = corrupted again. Markus