From owner-freebsd-net@freebsd.org Fri May 11 17:25:00 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F4A9FAD484 for ; Fri, 11 May 2018 17:25:00 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CB7697D9DC; Fri, 11 May 2018 17:24:59 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id w4BHOtEh026983; Fri, 11 May 2018 19:24:55 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 8A96A7E2; Fri, 11 May 2018 19:24:55 +0200 (CEST) Message-ID: <5AF5D1E6.2090301@omnilan.de> Date: Fri, 11 May 2018 19:24:54 +0200 From: Harry Schmalzbauer Organization: OmniLAN User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; de-DE; rv:1.9.2.8) Gecko/20100906 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: Stephen Hurd CC: mmacy@mattmacy.io, "freebsd-net@freebsd.org" , Stephen Hurd , Kevin Bowling Subject: Re: iflib-if_em tests with HEAD and lagg panic [Was: Re: svn commit: r333338 - in stable/11/sys: dev/bnxt kern net sys] References: <201805072142.w47LgN1R041002@repo.freebsd.org> <5AF16B8B.7030703@omnilan.de> <5AF17134.7020602@omnilan.de> <5AF1CF0F.4040909@omnilan.de> <65972f0d-2873-42ea-464c-a3db543abafb@freebsd.org> <5AF1E073.5010701@omnilan.de> <5AF4875C.5000201@omnilan.de> <5AF4891A.6030904@omnilan.de> <5AF48F76.4050301@omnilan.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: ACL 130 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Fri, 11 May 2018 19:24:57 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 17:25:00 -0000 Bezüglich Stephen Hurd's Nachricht vom 10.05.2018 21:55 (localtime): > Ok, the review is updated with the EBR. If you can update your tree to > r333466 or newer, apply the patch and retest, that would be great. It > seems to be working here. I took out the sys/net/if.c, sys/net/if_var.h and sys/conf/kmod.mk hunks, since these were commited in r333469. Happy to confirm that there are no more LORs occuring when creating/using if_lagg(4), neither with the hartwell/clarkville sisters, nor with kawela twins. Tested with r333486 and latest https://reviews.freebsd.org/D15355 as of this writing. Brief balancing/failover tests also inidcate excellent condition for those 3 iflib-NICs. Only did very simple workloads (with IPv6 NFSv4), but so far nothing uncommon in any area. Also, I cannot reproduce the link status failure when removing the TP connection of the i217 NIC (will update the separate thread). Thanks a lot for that quick fix, -Harry