Date: Thu, 27 Aug 1998 02:27:52 +0100 From: Roger Hardiman <roger@cs.strath.ac.uk> To: freebsd-alpha@FreeBSD.ORG Subject: Recent Alpha typecast to brooktre848.c Message-ID: <35E4B618.56FD@cs.strath.ac.uk>
next in thread | raw e-mail | index | archive | help
Hi, I work on the bt848 driver and was looking at the recent typecast change from "u_long" to "(uintptr_t) (void*)" in the driver. Logs state this was for the Alpha kernel. I think this may be incorrect. < *(*dma_prog)++ = (uintptr_t) (void *) *target_buffer; --- > *(*dma_prog)++ = (u_long) *target_buffer; The block of memory *dma_prog is pointing to is the instruction list for the bt848 chip's internal RISC processor. This is a set of 32 bit instructions. uintptr_t is defined as an unsigned long in Alpha/types.h so should this be a typecast to u_int32 and not uintptr_t Can someone working on this drop me an email. There are lots of other (u_long) type casts in the driver when writing to the dma_prog buffer which may need fixing. Cheers Roger Hardiman To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35E4B618.56FD>