Date: Sun, 26 May 2013 23:51:25 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Glen Barber <gjb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Stefan Esser <se@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r250972 - head/usr.bin/patch Message-ID: <20130526215125.GC1381@garage.freebsd.pl> In-Reply-To: <20130525051127.GP1756@glenbarber.us> References: <201305241854.r4OIsqdU043683@svn.freebsd.org> <20130525051127.GP1756@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
--7gGkHNMELEOhSGF6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 25, 2013 at 01:11:27AM -0400, Glen Barber wrote: > On Fri, May 24, 2013 at 06:54:52PM +0000, Stefan Esser wrote: > > Author: se > > Date: Fri May 24 18:54:52 2013 > > New Revision: 250972 > > URL: http://svnweb.freebsd.org/changeset/base/250972 > >=20 >=20 > > [...] >=20 > > @@ -977,7 +977,7 @@ spew_output(void) > > #endif > > if (input_lines) > > copy_till(input_lines, true); /* dump remainder of file */ > > - rv =3D ferror(ofp) =3D=3D 0 && fclose(ofp) =3D=3D 0; > > + rv =3D ferror(ofp) =3D=3D 0 & fclose(ofp) =3D=3D 0; > > ofp =3D NULL; > > return rv; > > } > >=20 >=20 > This breaks head/. Not to mention that it is really ugly and without any comment it looks like a typo. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --7gGkHNMELEOhSGF6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iEYEARECAAYFAlGig90ACgkQForvXbEpPzRpnQCfd2ouzLBvqchMOT3sZ5z4iGbq INsAn0KWj1LFfJkqLSW2bdrmAC1SeHdl =etOR -----END PGP SIGNATURE----- --7gGkHNMELEOhSGF6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130526215125.GC1381>