From owner-freebsd-ports@FreeBSD.ORG Tue Dec 6 17:11:25 2005 Return-Path: X-Original-To: freebsd-ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1100A16A41F for ; Tue, 6 Dec 2005 17:11:25 +0000 (GMT) (envelope-from itetcu@people.tecnik93.com) Received: from relay.rdsnet.ro (gimli.rdsnet.ro [193.231.236.70]) by mx1.FreeBSD.org (Postfix) with SMTP id B2F2643D64 for ; Tue, 6 Dec 2005 17:11:20 +0000 (GMT) (envelope-from itetcu@people.tecnik93.com) Received: (qmail 2992 invoked from network); 6 Dec 2005 17:11:12 -0000 Received: from unknown (HELO smtp.rdsnet.ro) (62.231.74.130) by smtp1-133.rdsnet.ro with SMTP; 6 Dec 2005 17:11:12 -0000 Received: (qmail 10654 invoked by uid 89); 6 Dec 2005 17:11:11 -0000 Received: from unknown (HELO it.buh.tecnik93.com) (81.196.204.98) by 0 with SMTP; 6 Dec 2005 17:11:11 -0000 Received: from it.buh.tecnik93.com (localhost [127.0.0.1]) by it.buh.tecnik93.com (Postfix) with ESMTP id C0112B847; Tue, 6 Dec 2005 19:11:07 +0200 (EET) Date: Tue, 6 Dec 2005 19:11:04 +0200 From: Ion-Mihai Tetcu To: Doug Barton Message-ID: <20051206191104.6402884e@it.buh.tecnik93.com> In-Reply-To: <4390AF40.1060600@FreeBSD.org> References: <4390AF40.1060600@FreeBSD.org> X-Mailer: Sylpheed-Claws 1.9.100 (GTK+ 2.8.8; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: oli@isnic.is, freebsd-ports@FreeBSD.org Subject: USE_RC_SUBR and local_startup scripts in the base rcorder X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2005 17:11:25 -0000 On Fri, 02 Dec 2005 12:32:00 -0800 Doug Barton wrote: > Howdy, > > The change I warned about the other day has now been made in HEAD. > I've attached a patch that provides an example of how to convert a > port (in this case nsd), to take advantage of the new system. [ ... ] > Once most of the bogons have been shaken out with this change in > HEAD, I plan to MFC it to RELENG_6 ASAP, definitely before > 6.1-RELEASE. So, we need your help to try and update these scripts as > soon as possible as well. [ ... ] Do you plan to MFC in 5-STABLE and 4-STABLE also ? USE_RC_SUBR= some_rc_file.in won't work with both old and new style scripts because bsd.port.mk adds .sh to ${USE_RC_SUBR} at install time The way it is now we either have to replicate USE_RC_SUBR logic from bsd.port.mk in ech port; or patch bsd.port.mk to add .sh extension only for OSVERSION <= 700006 (and after MFC 60000x, ...). The former would either; - assume scripts ending in .sh.in (i.e. files/script.sh.in) are old style and those ending only in .in are new style and install the former unconditionally as "script.sh" and the later as "script" for OSVERSION > 700006 and "script.sh" for the rest. (If we go this way we have to check for each port with USE_RC_SUBR= script.in that script.in is a new style script) - or drop adding .sh to ${USE_RC_SUBR } from bsd.port.mk (and convert all scrips to the new way) :-) I'm willing to work on either solution rather that re-writing my ports each MFC in various branches. Of course, for the second solution the maintainers of the respective ports are much more knowledgeable that me on what that port REQUIRES. I'd be really happy to know if we go for a general solution or I patch my ports and send-pr for them tonight. Thanks, -- IOnut - Unregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" Yes, it is written. Good shall always destroy evil. -- Sirah the Yang, "The Omega Glory", stardate unknown