Date: Thu, 15 Nov 2007 10:29:51 -0800 From: Julian Elischer <julian@elischer.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: cvs-src@freebsd.org, Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_kse.c Message-ID: <473C901F.1080906@elischer.org> In-Reply-To: <20071115181401.GA17094@troutmask.apl.washington.edu> References: <200711151416.lAFEGKJ6059040@repoman.freebsd.org> <473C865D.8070809@elischer.org> <20071115181401.GA17094@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Steve Kargl wrote: > On Thu, Nov 15, 2007 at 09:48:13AM -0800, Julian Elischer wrote: >> Gleb Smirnoff wrote: >>> glebius 2007-11-15 14:16:20 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern kern_kse.c >>> Log: >>> Fix build. >> thanks.. I need to remember to stop applying patches >> from build tree to checkin tree by hand. >> >> the trouble is I can't commit from my current test machine (no >> internet access) so after testing, I make a patch and move to >> to my commit machine, where I can commit it, but >> when it's a small patch, one is always tempted to >> do it by hand and then ... >> >> Julian, repeat after me.. >> >> "no matter how small the change, use diff + patch to move it across." > > After applying the patch on your commit machine, is it too > difficult to actually retest before committing? This would > catch the broken commit before it becomes a Tinderbox issue. > > Seems to be a QA problem on your part. yes.. but I can't do a compile from my mac. (my commit machine). The answer is to be rigorous about how I move the patch from the build machine to the commit machine. This is a temporary situation. new infrastructure will let me commit from my build machine again. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?473C901F.1080906>