Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Apr 2005 14:02:01 +0200
From:      =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@DeepCore.dk>
To:        Wiktor Niesiobedzki <bsd@w.evip.pl>
Cc:        sos@FreeBSD.ORG
Subject:   Re: ATA MkIII - Hang after resume solution
Message-ID:  <425915B9.3000606@DeepCore.dk>
In-Reply-To: <20050410111202.GA5980@dln55.neoplus.adsl.tpnet.pl>
References:  <20050410111202.GA5980@dln55.neoplus.adsl.tpnet.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
Wiktor Niesiobedzki wrote:
> Hi,
>=20
> I think I found solution to the problem, that after MkIII disks does no=
t
> reinit. Solution is simple:
>=20
> --- /usr/src/sys/dev/ata/ata-pci.c      Fri Apr  8 11:37:47 2005
> +++ /tmp/ata-pci.c      Sun Apr 10 13:09:48 2005
> @@ -599,8 +599,8 @@
>      DEVMETHOD(device_attach,    ata_pcichannel_attach),
>      DEVMETHOD(device_detach,    ata_pcichannel_detach),
>      DEVMETHOD(device_shutdown,  bus_generic_shutdown),
> -    DEVMETHOD(device_suspend,   bus_generic_suspend),
> -    DEVMETHOD(device_resume,    bus_generic_resume),
> +    DEVMETHOD(device_suspend,   ata_suspend),
> +    DEVMETHOD(device_resume,    ata_resume),
> =20
>      /* ATA methods */
>      DEVMETHOD(ata_setmode,      ata_pcichannel_setmode),
>=20
> This is rollback of changes introduced by MkIII. After that change
> suspend/resume works again.
>=20
> Can anybody review this?

I'll look into this and try to find out when/how this got changed.
Looks like a good catch though! thanks!

--=20

-S=F8ren




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?425915B9.3000606>