From owner-cvs-all Sun Sep 15 0:34:55 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6744137B400; Sun, 15 Sep 2002 00:34:54 -0700 (PDT) Received: from critter.freebsd.dk (port757.uc1-esp.isdn-lan.cybercity.dk [212.242.98.245]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0140743E6E; Sun, 15 Sep 2002 00:34:53 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g8F7YXBQ080184; Sun, 15 Sep 2002 09:34:34 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Matthew Dillon Cc: Bruce Evans , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/sys bio.h In-Reply-To: Your message of "Sat, 14 Sep 2002 17:42:25 PDT." <200209150042.g8F0gPF8053917@apollo.backplane.com> Date: Sun, 15 Sep 2002 09:34:32 +0200 Message-ID: <80183.1032075272@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200209150042.g8F0gPF8053917@apollo.backplane.com>, Matthew Dillon w rites: >:> >:> Well, the buffer is owned at the time of the BIO_DONE and you have >:> a lock structure sitting right there, why not simply use the >:> lock structure's interlock? Note I said 'interlock' here, not the >:> main lock. >: >:struct bio != struct buf >: >:-- >:Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > > Well, so? struct bio has access to struct buf via _bio_buf. Only some struct bio's come from a struct buf. > I do not think a timeout is a good solution. I don't care what you think until you have at least found out what what we are talking about here. You could start out by finding the places which call biowait() in the first place, then you'll probably (no guarantees) see how marginal the issue under discussion is. Preferably you'll just leave me alone instead. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message