From owner-freebsd-stable Sun May 17 17:35:26 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA26751 for freebsd-stable-outgoing; Sun, 17 May 1998 17:35:26 -0700 (PDT) (envelope-from owner-freebsd-stable@FreeBSD.ORG) Received: from cesit1.unifi.it (cesit1.unifi.it [150.217.1.31]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA26639 for ; Sun, 17 May 1998 17:34:31 -0700 (PDT) (envelope-from ugo@dsi.UNIFI.IT) Received: from aguirre.dsi.unifi.it by CESIT1.UNIFI.IT (PMDF V5.1-10 #23168) with SMTP id <01IX5VHF5JEY00018G@CESIT1.UNIFI.IT> for freebsd-stable@FreeBSD.ORG; Mon, 18 May 1998 02:35:00 MET Received: from dsi.unifi.it (com4.unifi.it) by aguirre.dsi.unifi.it (4.1/SMI-4.1) id AA00454; Fri, 15 May 1998 23:22:58 +0200 Received: from pegasus.home.net (pegasus.home.net [192.168.1.3]) by dsi.unifi.it (8.8.8/8.8.8) with ESMTP id OAA00267; Sun, 17 May 1998 14:24:28 +0200 (MET DST envelope-from ugo) Received: (from ugo@localhost) by pegasus.home.net (8.8.8/8.8.7) id OAA00302; Sun, 17 May 1998 14:24:28 +0200 (MET DST) Date: Sun, 17 May 1998 14:24:28 +0200 (MET DST) From: Ugo Paternostro Subject: Re: mount_msdos and msdosfs for VFAT/FAT32 access In-reply-to: <199805140039.JAA00329@pudding.carrot.kansai.oki.co.jp> To: Hideki Yamamoto Cc: freebsd-stable@FreeBSD.ORG Message-id: Organization: Not an organization MIME-version: 1.0 X-Mailer: XFMail 1.2 [p0] on FreeBSD Content-type: multipart/mixed; boundary="_=XFMail.1.2.p0.FreeBSD:980517142428:233=_" X-Priority: 3 (Normal) Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk This message is in MIME format --_=XFMail.1.2.p0.FreeBSD:980517142428:233=_ Content-Type: text/plain; charset=us-ascii On 14-May-98 Hideki Yamamoto wrote about "Re: mount_msdos and msdosfs for VFAT/FAT32 access": >>cannot make world because it fails building the dependencies: you are looking > > Thank you for your patch. You're welcome. BTW, I don't know if *that* is the Right Way (Tm). Please review. > I will fix my web page next time (in one or two weeks). As you are going to do that, please consider including the attached patch: this one will merge all -current (17th May, 00:30 UTC) changes in, plus it fixes a warning about a missing */ at line 252 of vfsops and (TADAAAAA ;-) it fixes mount -p problem and my export problems. Please check it against your (u)mount problem. Now I got: ugo@pegasus:~/temp [0]> mount -p [...some stuff deleted...] /dev/sd0s1 /mnt/windows95 msdos rw 0 0 /dev/sd0s5 /mnt/limbo msdos rw 0 0 /dev/wd0s1 /mnt/xchange_1 msdos rw 0 0 /dev/wd2s1 /mnt/xchange_2 msdos rw 0 0 [...some stuff deleted...] And no more "bad export line for blah blah" when I mount something else. I found we were missing a "sbp->f_type = MOUNT_MSDOS;" that is present in -stable sources at the beginning of msdosfs_statfs. Somehow -current go there with that field initialized to the right value. Someone with some knowledge of msdosfs should explain why. ># I started testing new -current source. It does not seem to be ># stable. I'm going to test those too. Please note that the patch includes them. Which kind of instability are you making reference to? I could try to reproduce it here. > Hideki Yamamoto (hyama@acm.org) Bye, UP --_=XFMail.1.2.p0.FreeBSD:980517142428:233=_ Content-Disposition: attachment; filename="msdosfs-980517.diff" Content-Transfer-Encoding: base64 Content-Description: msdosfs-980517.diff Content-Type: application/octet-stream; name=msdosfs-980517.diff; SizeOnDisk=5301 ZGlmZiAtdXJOIG1zZG9zZnMtMjJYLTk4MDUwNS9tc2Rvc2ZzX2xvb2t1cC5jIG1zZG9zZnMvbXNk b3Nmc19sb29rdXAuYwotLS0gbXNkb3Nmcy0yMlgtOTgwNTA1L21zZG9zZnNfbG9va3VwLmMJVHVl IE1heSAgNSAwMjo0ODo1MiAxOTk4CisrKyBtc2Rvc2ZzL21zZG9zZnNfbG9va3VwLmMJU3VuIE1h eSAxNyAxMDo1NzoxMiAxOTk4CkBAIC0xLDQgKzEsNCBAQAotLyoJJElkOiBtc2Rvc2ZzX2xvb2t1 cC5jLHYgMS4yMiAxOTk4LzAyLzI2IDA2OjQ1OjQ0IG1zbWl0aCBFeHAgJCAqLworLyoJJElkOiBt c2Rvc2ZzX2xvb2t1cC5jLHYgMS4yMyAxOTk4LzA1LzA5IDA5OjM2OjM4IGR0IEV4cCAkICovCiAv KgkkTmV0QlNEOiBtc2Rvc2ZzX2xvb2t1cC5jLHYgMS4zNyAxOTk3LzExLzE3IDE1OjM2OjU0IHdz IEV4cCAkCSovCiAKIC8qLQpAQCAtMzYwLDcgKzM2MCw3IEBACiAJCQkJICogdGhpcyBsb29rdXAu CiAJCQkJICovCiAJCQkJZHAtPmRlX2ZuZG9mZnNldCA9IGRpcm9mZjsKLQkJCQlkcC0+ZGVfZm5k Y250ID0gd2luY250OworCQkJCWRwLT5kZV9mbmRjbnQgPSB3aW5jbnQgLSAxOwogCiAJCQkJZ290 byBmb3VuZDsKIAkJCX0KZGlmZiAtdXJOIG1zZG9zZnMtMjJYLTk4MDUwNS9tc2Rvc2ZzX3Zmc29w cy5jIG1zZG9zZnMvbXNkb3Nmc192ZnNvcHMuYwotLS0gbXNkb3Nmcy0yMlgtOTgwNTA1L21zZG9z ZnNfdmZzb3BzLmMJVHVlIE1heSAgNSAwOToxMDowOCAxOTk4CisrKyBtc2Rvc2ZzL21zZG9zZnNf dmZzb3BzLmMJU3VuIE1heSAxNyAxNDowMDozMSAxOTk4CkBAIC0xLDQgKzEsNCBAQAotLyoJJElk OiBtc2Rvc2ZzX3Zmc29wcy5jLHYgMS4zNCAxOTk4LzA0LzI5IDEyOjU1OjUxIGR0IEV4cCAkICov CisvKgkkSWQ6IG1zZG9zZnNfdmZzb3BzLmMsdiAxLjM1IDE5OTgvMDUvMDYgMDU6Mjk6MzggbXNt aXRoIEV4cCAkICovCiAvKgkkTmV0QlNEOiBtc2Rvc2ZzX3Zmc29wcy5jLHYgMS41MSAxOTk3LzEx LzE3IDE1OjM2OjU4IHdzIEV4cCAkCSovCiAKIC8qLQpAQCAtMjQ4LDcgKzI0OCw3IEBACiAjaWZk ZWYgRkJTRENVUgogCWlmIChhcmdzLm1hZ2ljICE9IE1TRE9TRlNfQVJHU01BR0lDKQogCQlhcmdz LmZsYWdzID0gMDsKLSNlbmRpZiAvKiBGQlNEQ1VSCisjZW5kaWYgLyogRkJTRENVUiAqLwogCS8q CiAJICogSWYgdXBkYXRpbmcsIGNoZWNrIHdoZXRoZXIgY2hhbmdpbmcgZnJvbSByZWFkLW9ubHkg dG8KIAkgKiByZWFkL3dyaXRlOyBpZiB0aGVyZSBpcyBubyBkZXZpY2UgbmFtZSwgdGhhdCdzIGFs bCB3ZSBkby4KQEAgLTk0Miw2ICs5NDIsMTAgQEAKIAlzdHJ1Y3QgbXNkb3Nmc21vdW50ICpwbXA7 CiAKIAlwbXAgPSBWRlNUT01TRE9TRlMobXApOworI2lmbmRlZiBGQlNEQ1VSCisJc2JwLT5mX3R5 cGUgPSBNT1VOVF9NU0RPUzsKKyNlbmRpZiAvKiBGQlNEQ1VSICovCisKIAlzYnAtPmZfYnNpemUg PSBwbXAtPnBtX2JwY2x1c3RlcjsKIAlzYnAtPmZfaW9zaXplID0gcG1wLT5wbV9icGNsdXN0ZXI7 CiAJc2JwLT5mX2Jsb2NrcyA9IHBtcC0+cG1fbm1icm9mY2x1c3RlcnM7CkBAIC05NTIsOCArOTU2 LDYgQEAKIAlpZiAoc2JwICE9ICZtcC0+bW50X3N0YXQpIHsKICNpZmRlZiBGQlNEQ1VSCiAJCXNi cC0+Zl90eXBlID0gbXAtPm1udF92ZmMtPnZmY190eXBlbnVtOwotI2Vsc2UKLQkJc2JwLT5mX3R5 cGUgPSBNT1VOVF9NU0RPUzsKICNlbmRpZiAvKiBGQlNEQ1VSICovCiAJCWJjb3B5KG1wLT5tbnRf c3RhdC5mX21udG9ubmFtZSwgc2JwLT5mX21udG9ubmFtZSwgTU5BTUVMRU4pOwogCQliY29weSht cC0+bW50X3N0YXQuZl9tbnRmcm9tbmFtZSwgc2JwLT5mX21udGZyb21uYW1lLCBNTkFNRUxFTik7 CkBAIC0xMTI4LDkgKzExMzAsNiBAQAogCW1zZG9zZnNfc3RhdGZzLAogCW1zZG9zZnNfc3luYywK IAltc2Rvc2ZzX3ZnZXQsCi0jaWZkZWYgRkJTRENVUgotCXZmc192cmVsZSwKLSNlbmRpZiAvKiBG QlNEQ1VSICovCiAJbXNkb3Nmc19maHRvdnAsCiAJbXNkb3Nmc192cHRvZmgsCiAJbXNkb3Nmc19p bml0CmRpZmYgLXVyTiBtc2Rvc2ZzLTIyWC05ODA1MDUvbXNkb3Nmc192bm9wcy5jIG1zZG9zZnMv bXNkb3Nmc192bm9wcy5jCi0tLSBtc2Rvc2ZzLTIyWC05ODA1MDUvbXNkb3Nmc192bm9wcy5jCVN1 biBBcHIgMjYgMDI6NTg6MTcgMTk5OAorKysgbXNkb3Nmcy9tc2Rvc2ZzX3Zub3BzLmMJU3VuIE1h eSAxNyAxMToxNTo0OSAxOTk4CkBAIC0xLDQgKzEsNCBAQAotLyoJJElkOiBtc2Rvc2ZzX3Zub3Bz LmMsdiAxLjY3IDE5OTgvMDMvMjYgMjA6NTI6NTggcGhrIEV4cCAkICovCisvKgkkSWQ6IG1zZG9z ZnNfdm5vcHMuYyx2IDEuNjggMTk5OC8wNS8wNyAwNDo1ODo0MiBtc21pdGggRXhwICQgKi8KIC8q CSROZXRCU0Q6IG1zZG9zZnNfdm5vcHMuYyx2IDEuNjggMTk5OC8wMi8xMCAxNDoxMDowNCBtcmcg RXhwICQJKi8KIAogLyotCkBAIC0yMTksMTMgKzIxOSwxMSBAQAogCQlnb3RvIGJhZDsKIAlpZiAo KGNucC0+Y25fZmxhZ3MgJiBTQVZFU1RBUlQpID09IDApCiAJCXpmcmVlKG5hbWVpX3pvbmUsIGNu cC0+Y25fcG5idWYpOwotCXZwdXQoYXAtPmFfZHZwKTsKIAkqYXAtPmFfdnBwID0gREVUT1YoZGVw KTsKIAlyZXR1cm4gKDApOwogCiBiYWQ6CiAJemZyZWUobmFtZWlfem9uZSwgY25wLT5jbl9wbmJ1 Zik7Ci0JdnB1dChhcC0+YV9kdnApOwogCXJldHVybiAoZXJyb3IpOwogfQogCkBAIC0yNTAsNyAr MjQ4LDYgQEAKIAogCWRlZmF1bHQ6CiAJCXpmcmVlKG5hbWVpX3pvbmUsIGFwLT5hX2NucC0+Y25f cG5idWYpOwotCQl2cHV0KGFwLT5hX2R2cCk7CiAJCXJldHVybiAoRUlOVkFMKTsKIAl9CiAJLyog Tk9UUkVBQ0hFRCAqLwpAQCAtMTEwMiw5ICsxMDk5LDkgQEAKIAkJc3RydWN0IGNvbXBvbmVudG5h bWUgKmFfY25wOwogCX0gKi8gKmFwOwogewotCWludCBlcnJvcjsKIAlzdHJ1Y3QgZGVub2RlICpk ZXAgPSBWVE9ERShhcC0+YV92cCk7CiAJc3RydWN0IGRlbm9kZSAqZGRlcCA9IFZUT0RFKGFwLT5h X2R2cCk7CisJaW50IGVycm9yOwogCiAJaWYgKGFwLT5hX3ZwLT52X3R5cGUgPT0gVkRJUikKIAkJ ZXJyb3IgPSBFUEVSTTsKQEAgLTExMTMsMTIgKzExMTAsNiBAQAogI2lmZGVmIE1TRE9TRlNfREVC VUcKIAlwcmludGYoIm1zZG9zZnNfcmVtb3ZlKCksIGRlcCAlcCwgdl91c2Vjb3VudCAlZFxuIiwg ZGVwLCBhcC0+YV92cC0+dl91c2Vjb3VudCk7CiAjZW5kaWYKLQlpZiAoZGRlcCA9PSBkZXApCi0J CXZyZWxlKGFwLT5hX3ZwKTsKLQllbHNlCi0JCXZwdXQoYXAtPmFfdnApOwkvKiBjYXVzZXMgbXNk b3Nmc19pbmFjdGl2ZSgpIHRvIGJlIGNhbGxlZAotCQkJCSAqIHZpYSB2cmVsZSgpICovCi0JdnB1 dChhcC0+YV9kdnApOwogCXJldHVybiAoZXJyb3IpOwogfQogCkBAIC0xMTM2LDggKzExMjcsNyBA QAogCX0gKi8gKmFwOwogewogCVZPUF9BQk9SVE9QKGFwLT5hX3RkdnAsIGFwLT5hX2NucCk7Ci0J dnB1dChhcC0+YV90ZHZwKTsKLQlyZXR1cm4gRU9QTk9UU1VQUDsKKwlyZXR1cm4gKEVPUE5PVFNV UFApOwogfQogCiAvKgpAQCAtMTYwOSwxNSArMTU5OSwxNSBAQAogCX0gKi8gKmFwOwogewogCXN0 cnVjdCBjb21wb25lbnRuYW1lICpjbnAgPSBhcC0+YV9jbnA7Ci0Jc3RydWN0IGRlbm9kZSBuZGly ZW50OwogCXN0cnVjdCBkZW5vZGUgKmRlcDsKIAlzdHJ1Y3QgZGVub2RlICpwZGVwID0gVlRPREUo YXAtPmFfZHZwKTsKLQlpbnQgZXJyb3I7Ci0JaW50IGJuOwotCXVfbG9uZyBuZXdjbHVzdGVyLCBw Y2w7CiAJc3RydWN0IGRpcmVudHJ5ICpkZW5wOwogCXN0cnVjdCBtc2Rvc2ZzbW91bnQgKnBtcCA9 IHBkZXAtPmRlX3BtcDsKIAlzdHJ1Y3QgYnVmICpicDsKKwl1X2xvbmcgbmV3Y2x1c3RlciwgcGNs OworCWludCBibjsKKwlpbnQgZXJyb3I7CisJc3RydWN0IGRlbm9kZSBuZGlyZW50OwogCXN0cnVj dCB0aW1lc3BlYyB0czsKIAogCS8qCkBAIC0xNzA4LDcgKzE2OTgsNiBAQAogCQlnb3RvIGJhZDsK IAlpZiAoKGNucC0+Y25fZmxhZ3MgJiBTQVZFU1RBUlQpID09IDApCiAJCXpmcmVlKG5hbWVpX3pv bmUsIGNucC0+Y25fcG5idWYpOwotCXZwdXQoYXAtPmFfZHZwKTsKIAkqYXAtPmFfdnBwID0gREVU T1YoZGVwKTsKIAlyZXR1cm4gKDApOwogCkBAIC0xNzE2LDcgKzE3MDUsNiBAQAogCWNsdXN0ZXJm cmVlKHBtcCwgbmV3Y2x1c3RlciwgTlVMTCk7CiBiYWQyOgogCXpmcmVlKG5hbWVpX3pvbmUsIGNu cC0+Y25fcG5idWYpOwotCXZwdXQoYXAtPmFfZHZwKTsKIAlyZXR1cm4gKGVycm9yKTsKIH0KIApA QCAtMTczMiw2ICsxNzIwLDcgQEAKIAlyZWdpc3RlciBzdHJ1Y3Qgdm5vZGUgKmR2cCA9IGFwLT5h X2R2cDsKIAlyZWdpc3RlciBzdHJ1Y3QgY29tcG9uZW50bmFtZSAqY25wID0gYXAtPmFfY25wOwog CXJlZ2lzdGVyIHN0cnVjdCBkZW5vZGUgKmlwLCAqZHA7CisJc3RydWN0IHByb2MgKnAgPSBjbnAt PmNuX3Byb2M7CiAJaW50IGVycm9yOwogCQogCWlwID0gVlRPREUodnApOwpAQCAtMTc2MywyMCAr MTc1MiwyMiBAQAogCS8qCiAJICogVGhpcyBpcyB3aGVyZSB3ZSBkZWNyZW1lbnQgdGhlIGxpbmsg Y291bnQgaW4gdGhlIHBhcmVudAogCSAqIGRpcmVjdG9yeS4gIFNpbmNlIGRvcyBmaWxlc3lzdGVt cyBkb24ndCBkbyB0aGlzIHdlIGp1c3QgcHVyZ2UKLQkgKiB0aGUgbmFtZSBjYWNoZSBhbmQgbGV0 IGdvIG9mIHRoZSBwYXJlbnQgZGlyZWN0b3J5IGRlbm9kZS4KKwkgKiB0aGUgbmFtZSBjYWNoZS4K IAkgKi8KIAljYWNoZV9wdXJnZShkdnApOwotCXZwdXQoZHZwKTsKLQlkdnAgPSBOVUxMOworI2lm ZGVmIEZCU0RDVVIKKwlWT1BfVU5MT0NLKGR2cCwgMCwgcCk7CisjZWxzZQorCVZPUF9VTkxPQ0so ZHZwKTsKKyNlbmRpZiAvKiBGQlNEQ1VSICovCiAJLyoKIAkgKiBUcnVuY2F0ZSB0aGUgZGlyZWN0 b3J5IHRoYXQgaXMgYmVpbmcgZGVsZXRlZC4KIAkgKi8KLQllcnJvciA9IGRldHJ1bmMoaXAsICh1 X2xvbmcpMCwgSU9fU1lOQywgY25wLT5jbl9jcmVkLCBjbnAtPmNuX3Byb2MpOworCWVycm9yID0g ZGV0cnVuYyhpcCwgKHVfbG9uZykwLCBJT19TWU5DLCBjbnAtPmNuX2NyZWQsIHApOwogCWNhY2hl X3B1cmdlKHZwKTsKKworCXZuX2xvY2soZHZwLCBMS19FWENMVVNJVkUgfCBMS19SRVRSWSwgcCk7 CiBvdXQ6Ci0JaWYgKGR2cCkKLQkJdnB1dChkdnApOwotCXZwdXQodnApOwogCXJldHVybiAoZXJy b3IpOwogfQogCkBAIC0xNzk1LDcgKzE3ODYsNiBAQAogewogCXpmcmVlKG5hbWVpX3pvbmUsIGFw LT5hX2NucC0+Y25fcG5idWYpOwogCS8qIFZPUF9BQk9SVE9QKGFwLT5hX2R2cCwgYXAtPmFfY25w KTsgPz8/ICovCi0JdnB1dChhcC0+YV9kdnApOwogCXJldHVybiAoRU9QTk9UU1VQUCk7CiB9CiAK --_=XFMail.1.2.p0.FreeBSD:980517142428:233=_-- End of MIME message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message