From owner-freebsd-alpha Wed Sep 19 12:46:54 2001 Delivered-To: freebsd-alpha@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 5651337B410 for ; Wed, 19 Sep 2001 12:46:51 -0700 (PDT) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id f8JJknj29673; Wed, 19 Sep 2001 12:46:49 -0700 (PDT) (envelope-from obrien) Date: Wed, 19 Sep 2001 12:46:49 -0700 From: "David O'Brien" To: "Andrew M. Miklic" Cc: freebsd-alpha@FreeBSD.ORG Subject: Re: TGA driver Message-ID: <20010919124649.A29411@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <3BA8C3A0.3070709@attglobal.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3BA8C3A0.3070709@attglobal.net>; from miklic@attglobal.net on Wed, Sep 19, 2001 at 10:11:12AM -0600 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Wed, Sep 19, 2001 at 10:11:12AM -0600, Andrew M. Miklic wrote: > I have tried unsuccessfuly to get it committed by various people I have sent you feedback on the files (Date: Tue, 11 Sep 2001 22:19:14 -0700). Did you not get my email? Please go over the TGA files and remove all the embedded comments that remove code. They should be properly wrapped in #if 0 / #endif pairs. Also please read style(9). Functions too long to be fit on one line are indented by 4 spaces, not lined up with the `('. I am also converting this to ANSI function definitions. I included my versions of your files (I spent 3 hrs cleaning them up) so you could diff them with what you have to see the needed changes and finish them. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message