From owner-freebsd-arm@FreeBSD.ORG Tue Aug 27 15:59:18 2013 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3FCCEB2B; Tue, 27 Aug 2013 15:59:18 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C3C092135; Tue, 27 Aug 2013 15:59:17 +0000 (UTC) Received: from [192.168.1.200] (p508F3337.dip0.t-ipconnect.de [80.143.51.55]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTP id EF1DC1C0C0692; Tue, 27 Aug 2013 17:59:15 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: ARM network trouble after recent mbuf changes From: Michael Tuexen In-Reply-To: Date: Tue, 27 Aug 2013 17:59:14 +0200 Content-Transfer-Encoding: 7bit Message-Id: <76A89374-49EB-4902-A92F-6B44DADFCF8D@freebsd.org> References: <1377550636.1111.156.camel@revolution.hippie.lan> <521BC472.7040804@freebsd.org> <521BD531.4090104@sbcglobal.net> <521C4CD9.4050308@freebsd.org> <20130827102810.37e2dfc7@bender> <20130827164055.4a757a13@bender> To: Warner Losh X-Mailer: Apple Mail (2.1508) Cc: freebsd-arm , Andre Oppermann X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Aug 2013 15:59:18 -0000 On Aug 27, 2013, at 5:56 PM, Warner Losh wrote: > > On Aug 27, 2013, at 9:40 AM, Andrew Turner wrote: > >> On Tue, 27 Aug 2013 07:26:03 -0600 >> Warner Losh wrote: >> >>> >>> On Aug 27, 2013, at 3:28 AM, Andrew Turner wrote: >>> >>>> On Tue, 27 Aug 2013 08:53:13 +0200 >>>> Andre Oppermann wrote: >>>>> Please try the patch below to confirm. If it fixes your problem >>>>> for now I'm going to commit as an immediate fix while searching >>>>> for a better long term stable solution. >>>>> >>>> >>>> I tried this with a CTASSERT to check if struct m_hdr is the correct >>>> length. In this test the size is incorrect. It appears __ILP32__ is >>>> not defined on ARM. >>>> >>>> I have tested a fix suggested by Hans Petter Selasky where we mark >>>> m_hdr with __aligned(8). With this change I can netboot a >>>> PandaBoard. >>> >>> Isn't that a bug with our arm compiler then? >> >> No, on ARM EABI the definition of the size of a struct is to be the >> smallest multiple of its alignment. As we are increasing the alignment >> to 8-byte and the struct without this alignment is not a multiple of >> 8-bytes adding this alignment will pad to struct to use the unused 4 >> bytes between this and the next struct. > > Wrong bug :) > > Is it not a bug that __ILP32__ is undefined? Is it used anywhere? I only found __LP64__ being used... Best regards Michael > > Warner > >> Andrew >>> >>> Warner >>> >>> >> > > _______________________________________________ > freebsd-arm@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" >