From owner-cvs-all Mon Nov 19 17:54:34 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 0676B37B416; Mon, 19 Nov 2001 17:54:26 -0800 (PST) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id fAK1sJi26798; Tue, 20 Nov 2001 01:54:20 GMT (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id fAK1sCv33540; Tue, 20 Nov 2001 01:54:12 GMT (envelope-from brian@freebsd-services.com) Message-Id: <200111200154.fAK1sCv33540@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: "Akinori MUSHA" Cc: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/share/man/man1 builtin.1 src/bin/sh Makefile builtins.def sh.1 src/bin/test test.1 test.c In-Reply-To: Message from "Akinori MUSHA" of "Tue, 20 Nov 2001 05:03:10 +0900." <86itc68r5t.wl@archon.local.idaemons.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 20 Nov 2001 01:54:11 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > At Mon, 19 Nov 2001 18:30:52 +0000, > Brian Somers wrote: > > This breaks sh: > > > > $ echo "program-not-found; test" | sh > > > > When testcmd() is given an argv[] of { "test", NULL } *and* an error > > has occurred, things go pear shaped. > > Thanks for catching it! Actually, even this: > > $ sh -c 'ls; test' > > coredumped. I found it to be a longstanding bug of test(1) which had > never been exposed, and fixed it by adding an argc/argv boundary > check. Wow, that was fast :*) Thanks ! > -- > / > /__ __ Akinori.org / MUSHA.org > / ) ) ) ) / FreeBSD.org / Ruby-lang.org > Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp > > "Somewhere out of a memory.. of lighted streets on quiet nights.." -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message