From owner-freebsd-current  Sat May 31 10:56:17 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id KAA01409
          for current-outgoing; Sat, 31 May 1997 10:56:17 -0700 (PDT)
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA01404
          for <freebsd-current@freefall.FreeBSD.org>; Sat, 31 May 1997 10:56:14 -0700 (PDT)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.8.5/8.8.5) id NAA08241;
	Sat, 31 May 1997 13:56:02 -0400 (EDT)
Date: Sat, 31 May 1997 13:56:02 -0400 (EDT)
From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Message-Id: <199705311756.NAA08241@khavrinen.lcs.mit.edu>
To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch)
Cc: freebsd-current@freefall.FreeBSD.org
Subject: Re: if.h inclusion of <sys/socket.h>
In-Reply-To: <19970531182404.ES51927@uriah.heep.sax.de>
References: <199705301551.LAA01946@khavrinen.lcs.mit.edu>
	<199705301601.SAA19086@gil.physik.rwth-aachen.de>
	<19970531182404.ES51927@uriah.heep.sax.de>
Sender: owner-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

<<On Sat, 31 May 1997 18:24:04 +0200, j@uriah.heep.sax.de (J Wunsch) said:

> As Christoph Kukulies wrote:
>> > Then bisdn should properly include <sys/socket.h> like every other
>> > client of <net/if.h> does.  The former is a prerequisite for the
>> > latter.
>> 
>> OK, Hellmuth, Gary, have you read this?

> BISDN does.  It's only that we can't emit updated BISDN releases, as
> you know.  It's already cleaned up in the BISDN CVS tree.

> It's however tangled inside some #ifdef spagghetti currently, and
> needs further cleanup.

> #if defined(__NetBSD__) || defined(__OpenBSD__)
> #include <sys/socket.h>
> #include <sys/select.h>
> #include <sys/poll.h>
> #endif

> #if defined(__FreeBSD__) && __FreeBSD__>=3
> #include <sys/socket.h>
> #endif
> #include <net/if.h>

> That's horrible.

There is no reason for the include of <sys/socket.h> to be
conditional.

-GAWollman

--
Garrett A. Wollman   | O Siem / We are all family / O Siem / We're all the same
wollman@lcs.mit.edu  | O Siem / The fires of freedom 
Opinions not those of| Dance in the burning flame
MIT, LCS, CRS, or NSA|                     - Susan Aglukark and Chad Irschick