From owner-freebsd-ports Tue Aug 22 22:59:17 2000 Delivered-To: freebsd-ports@freebsd.org Received: from guru.mired.org (zoom0-251.telepath.com [216.14.0.251]) by hub.freebsd.org (Postfix) with SMTP id DA6C337B43C for ; Tue, 22 Aug 2000 22:59:12 -0700 (PDT) Received: (qmail 84979 invoked by uid 100); 23 Aug 2000 05:59:11 -0000 From: Mike Meyer MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <14755.26670.902082.807613@guru.mired.org> Date: Wed, 23 Aug 2000 00:59:10 -0500 (CDT) To: "Matthew Emmerton" Cc: "Mike Meyer" , Subject: Re: ports/19458: Both /usr/ports/math/PDL and /usr/ports/pilot/coldsync have /usr/local dependencies. In-Reply-To: <003b01c00cc4$d7738790$1200a8c0@matt> References: <200008221302.GAA24581@freefall.freebsd.org> <14755.24530.848488.607626@guru.mired.org> <003b01c00cc4$d7738790$1200a8c0@matt> X-Mailer: VM 6.72 under 21.1 (patch 10) "Capitol Reef" XEmacs Lucid X-face: "5Mnwy%?j>IIV\)A=):rjWL~NB2aH[}Yq8Z=u~vJ`"(,&SiLvbbz2W`;h9L,Yg`+vb1>RG% *h+%X^n0EZd>TM8_IB;a8F?(Fb"lw'IgCoyM.[Lg#r\ Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Matthew Emmerton writes: > > sobomax@FreeBSD.org writes: > > > Synopsis: Both /usr/ports/math/PDL and /usr/ports/pilot/coldsync have > /usr/local dependencies. > > > > > > State-Changed-From-To: open->closed > > > State-Changed-By: sobomax > > > State-Changed-When: Tue Aug 22 06:01:24 PDT 2000 > > > State-Changed-Why: > > > You did it wrong. LOCALBASE *doesn't* control port's destination prefix, > PREFIX > > > variable should be used for this purpose instead. Please read Handbook > for > > > details. > > > > What do you mean by "it"? If you mean "setting the port's destination > > prefix", that I did right. PREFIX is set to LOCALBASE (see the > > Porter's Handbook, Section 15.12). If you mean something else, could > > you please provide details. > > What Section 15.12 means is that you should use ${PREFIX} throughout your > Makefiles. If, during a make, a value for ${PREFIX} isn't given on the > command line (such as make PREFIX=/var/tmp/, as in the example in > Section 17), then the ports subsystem will automatically substitute > ${LOCALBASE} for ${PREFIX}. ${LOCALBASE} is set by the ports subsystem > based on various parameters (such as USE_X_PREFIX), and can't be overridden > by the user. ${PREFIX} can. Hence, your makefiles should use ${PREFIX}. Correct, makefiles should use PREFIX for the names of their destination files (I have done that one wrong more than once) and LOCALBASE for references to files from other ports. However, did you read the PR? There are no makefiles, or changes to makefiles, attached. All I did was report a bug. Possibly it was the wrong bug. If you set LOCALBASE in /etc/make.conf, should ports that aren't in the X tree be installed in what I set LOCALBASE to? If so, then this port is (or maybe was) broken. If not, then damn near every port in the tree is broken. If I'm not supposed to set LOCALBASE in /etc/make.conf, then tell me where to set it, and I'll try again.