Date: Thu, 12 Aug 1999 22:00:03 -0700 (PDT) From: <jkoshy@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/10959: 3.1-STABLE crashes due to a floppy mount problem Message-ID: <199908130500.WAA58083@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/10959; it has been noted by GNATS.
From: <jkoshy@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc: Bruce Evans <bde@zeta.org.au>, phk@FreeBSD.org
Subject: Re: kern/10959: 3.1-STABLE crashes due to a floppy mount problem
Date: Thu, 12 Aug 1999 21:54:14 -0700 (PDT)
The following band-aid patch fixes the panic reported in PR kern/10959,
affecting both 3-STABLE and 4-CURRENT. It avoids the panic by behaving
more like the UFS code does. Could you please review?
I'm open to suggestions for a better fix for the panic.
Thanks,
Koshy
<jkoshy@freebsd.org>
Index: sys/msdosfs/msdosfs_vfsops.c
===================================================================
RCS file: /home/ncvs/src/sys/msdosfs/msdosfs_vfsops.c,v
retrieving revision 1.46
diff -u -r1.46 msdosfs_vfsops.c
--- msdosfs_vfsops.c 1999/08/08 18:42:54 1.46
+++ msdosfs_vfsops.c 1999/08/13 10:14:21
@@ -779,7 +779,6 @@
if (error)
return error;
pmp = VFSTOMSDOSFS(mp);
- pmp->pm_devvp->v_specmountpoint = NULL;
#ifdef MSDOSFS_DEBUG
{
struct vnode *vp = pmp->pm_devvp;
@@ -805,6 +804,9 @@
error = VOP_CLOSE(pmp->pm_devvp,
(pmp->pm_flags&MSDOSFSMNT_RONLY) ? FREAD : FREAD | FWRITE,
NOCRED, p);
+ if (error)
+ return (error);
+ pmp->pm_devvp->v_specmountpoint = NULL;
vrele(pmp->pm_devvp);
free(pmp->pm_inusemap, M_MSDOSFSFAT);
free(pmp, M_MSDOSFSMNT);
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908130500.WAA58083>