From owner-freebsd-current@FreeBSD.ORG Thu May 14 09:30:10 2015 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F0AB0562; Thu, 14 May 2015 09:30:09 +0000 (UTC) Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com [IPv6:2607:f8b0:4003:c01::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB3B516F7; Thu, 14 May 2015 09:30:09 +0000 (UTC) Received: by obblk2 with SMTP id lk2so49030307obb.0; Thu, 14 May 2015 02:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=WKLn7J5YiJBL3US6NM4JZAcA3kdhlQaPRuXvkeofnoc=; b=RUVnciGERLeSyEt/251u4svQNMWWMVmKpjhF42i92oycFUX5IM+09WJQytCx0Lmt98 E/ljiKqCuWk5RMMmcQIa+7hvqYCVL8FjvLj0h+yS5Gvgj37S0r8GQoCo6PKleFfeRFGM QPVQHDmBI/LVtvZCIvrXa/AZhC9xjkuSOsN8YrQAbgmw7XC/s32dIVu6hc9J9IjHGvbh ntgQNjsblV4IdNxalUMrmwJO6K8QtilOmzfa+ULSyyPq4iFib2KzE+33V7GwEKsOhBXS KyP3HmWTg3GkrhQyb4s/lTfKs72OnrWDIXzfQHc4mAzl7zm+TG6W3PPuPQhRJraRw2Xq H8Gw== X-Received: by 10.60.101.195 with SMTP id fi3mr2721750oeb.65.1431595808888; Thu, 14 May 2015 02:30:08 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:c178:acbe:4cc0:2fd4? ([2601:8:ab80:7d6:c178:acbe:4cc0:2fd4]) by mx.google.com with ESMTPSA id bt6sm14462973obd.0.2015.05.14.02.30.07 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 14 May 2015 02:30:08 -0700 (PDT) Subject: Re: Increase BUFSIZ to 8192 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_3D45A5D2-5BC5-4B7D-BFCE-0D489B5A074E"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Garrett Cooper In-Reply-To: <77803.1431590500@critter.freebsd.dk> Date: Thu, 14 May 2015 02:30:06 -0700 Cc: Ian Lepore , John-Mark Gurney , Adrian Chadd , Hans Petter Selasky , David Chisnall , Baptiste Daroussin , "current@freebsd.org" Message-Id: <72720EA2-C251-40B9-9EC0-702C07D5EDF9@gmail.com> References: <20150511230635.GA46991@ivaldir.etoilebsd.net> <20150512032307.GP37063@funkthat.com> <14994.1431412293@critter.freebsd.dk> <20150513080342.GE37063@funkthat.com> <55530CC3.1090204@selasky.org> <1431528249.1221.15.camel@freebsd.org> <20150513181347.GM37063@funkthat.com> <1431542835.1221.30.camel@freebsd.org> <77803.1431590500@critter.freebsd.dk> To: Poul-Henning Kamp X-Mailer: Apple Mail (2.1878.6) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2015 09:30:10 -0000 --Apple-Mail=_3D45A5D2-5BC5-4B7D-BFCE-0D489B5A074E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On May 14, 2015, at 1:01, Poul-Henning Kamp wrote: > -------- > In message <1431542835.1221.30.camel@freebsd.org>, Ian Lepore writes: >> On Wed, 2015-05-13 at 11:13 -0700, John-Mark Gurney wrote: >=20 >> As I've already pointed out, BUFSIZ appears in the >> base code over 2000 times. Where is the analysis of the impact an 8x >> change is going to have on all those uses? >=20 > Not to pick on Ian in particular, but I'm going to call bike-shed > on this discussion now. >=20 > Please just make it 4K on 32bit archs and 16K on 64 bit archs, and > get on with your lives. >=20 > If experience in -current (that's why developers run current, right = ?!) > documents that this was the wrong decision, we can revisit it. >=20 > Until then: Shut up and code. Baptiste=92s recommendation was related to md5 performance, so it might = be that (as you pointed out with MDXFileChunk), things might be less = performant in the application than they could be =97 but that=92s an = application bug (only helped by scaling issues with FreeBSD, = potentially). Until performance has been characterized on 32-bit vs = 64-bit architectures, blanket changing a value doesn=92t make sense. I think that changing buffers sized at BUFSIZ for md5/libmd5 probably = makes a lot more sense as that change is isolated and the end result = could be easily micro benchmarked. If/when we have an overall = characterization we can look at increasing the value across the board. Thanks! -NGie --Apple-Mail=_3D45A5D2-5BC5-4B7D-BFCE-0D489B5A074E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVVGseAAoJEMZr5QU6S73eXywIALZHKkiI/SycxRvlLjfEuU49 XvHLyOr5fOMGoQoCo/93XeEBtltV4KruFLPkcxg/UP21jL7ZP3kFeQK61l14erte V6ygAXDTtzbG3mAfNDhGWKoACggwXXdXnyEgczbje707wSo8IFpwt/lefKF/nJ+Y TRUKNsBMb7QK2/M8nCnuHRTBRelk0Y9g5QXcBztsPoKaRBTYtYo+BvV6p4+LUzFO TqhoHmXp/P5P2a6ryW9O0ESVWaukSZUsMpSejaiZxYo7KJQZyiXrJ9tvd2UCntCh ABnahnu1KmWwRRDIk9CC23zIM8FRMZGpnKNtEs8XwzV6OJtbewZ/qK0vojqe/mQ= =a30F -----END PGP SIGNATURE----- --Apple-Mail=_3D45A5D2-5BC5-4B7D-BFCE-0D489B5A074E--