From owner-svn-src-all@FreeBSD.ORG Mon Nov 21 10:51:12 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BCDE4106566C; Mon, 21 Nov 2011 10:51:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 1FA438FC0A; Mon, 21 Nov 2011 10:51:11 +0000 (UTC) Received: from alf.home (alf.kiev.zoral.com.ua [10.1.1.177]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id pALAp8VB022859 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 21 Nov 2011 12:51:08 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from alf.home (kostik@localhost [127.0.0.1]) by alf.home (8.14.5/8.14.5) with ESMTP id pALAp8AK034202; Mon, 21 Nov 2011 12:51:08 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by alf.home (8.14.5/8.14.5/Submit) id pALAp8Km034201; Mon, 21 Nov 2011 12:51:08 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: alf.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 21 Nov 2011 12:51:08 +0200 From: Kostik Belousov To: Sergey Kandaurov Message-ID: <20111121105108.GE50300@deviant.kiev.zoral.com.ua> References: <201111211036.pALAavS7039188@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sKTXwkTcrvVuA/Nz" Content-Disposition: inline In-Reply-To: <201111211036.pALAavS7039188@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227784 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2011 10:51:12 -0000 --sKTXwkTcrvVuA/Nz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 21, 2011 at 10:36:57AM +0000, Sergey Kandaurov wrote: > Author: pluknet > Date: Mon Nov 21 10:36:57 2011 > New Revision: 227784 > URL: http://svn.freebsd.org/changeset/base/227784 >=20 > Log: > Use the acquired reference to the vmspace instead of direct dereferenci= ng > of p->p_vmspace like it is done in sysctl_kern_proc_vmmap(). >=20 > Modified: > head/sys/kern/kern_proc.c >=20 > Modified: head/sys/kern/kern_proc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/kern_proc.c Mon Nov 21 08:12:36 2011 (r227783) > +++ head/sys/kern/kern_proc.c Mon Nov 21 10:36:57 2011 (r227784) > @@ -1528,7 +1528,7 @@ sysctl_kern_proc_ovmmap(SYSCTL_HANDLER_A > } > kve =3D malloc(sizeof(*kve), M_TEMP, M_WAITOK); > =20 > - map =3D &p->p_vmspace->vm_map; /* XXXRW: More locking required? */ > + map =3D &vm->vm_map; /* XXXRW: More locking required? */ It makes sense to remove the XXXRW comment, from both places. > vm_map_lock_read(map); > for (entry =3D map->header.next; entry !=3D &map->header; > entry =3D entry->next) { --sKTXwkTcrvVuA/Nz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk7KLRsACgkQC3+MBN1Mb4i0HQCffjla7xswBxEIbBOfZFVGDsTX 2wwAoJj8tZl9nb6bArOGisM20bP8cfDm =UAUL -----END PGP SIGNATURE----- --sKTXwkTcrvVuA/Nz--