Date: Sun, 25 Nov 2012 11:08:25 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Wesley Shields <wxs@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307565 - head/net/silc-client Message-ID: <20121125100824.GB33816@ithaqua.etoilebsd.net> In-Reply-To: <20121125032245.GB10784@atarininja.org> References: <201211191622.qAJGMZps097391@svn.freebsd.org> <20121120111700.GI71195@ithaqua.etoilebsd.net> <20121125032245.GB10784@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--TRYliJ5NKNqkz5bu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 24, 2012 at 10:22:45PM -0500, Wesley Shields wrote: > On Tue, Nov 20, 2012 at 12:17:00PM +0100, Baptiste Daroussin wrote: > > I know I already told you the following, but I think it is worth saying= it > > loudly for other people who don't know yet about OPTIONS_DEFINE_${arch} > >=20 > > regards, > > Bapt > >=20 > > On Mon, Nov 19, 2012 at 04:22:35PM +0000, Wesley Shields wrote: > > > Author: wxs > > > Date: Mon Nov 19 16:22:34 2012 > > > New Revision: 307565 > > > URL: http://svnweb.freebsd.org/changeset/ports/307565 > > >=20 > > ... > > > WANT_PERL=3D yes > > > =20 > > > -OPTIONS=3D PTHREADS "Enable pthreads support" off \ > > > - IPV6 "Enable IPv6 support" on \ > > > - ICONV "Enable international character support" on \ > > > - PERL "Enable perl support" on \ > > > - OPTIMIZED_ASM "Use assembler optimizations (i386 only)" on > > > +OPTIONS_DEFINE=3D PTHREADS IPV6 ICONV PERL OPTIMIZED_ASM > > > +PTHREADS_DESC=3D "Enable pthreads support" > > > +OPTIMIZED_ASM_DESC=3D "Use assembler optimizations (i386 only)" > > > +OPTIONS_DEFAULT=3D IPV6 ICONV PERL OPTIMIZED_ASM > >=20 > > OPTIONS_DEFINE=3D -PTHREADS IPV6 ICONV PERL > > OPTIONS_DEFINE_i386=3D OPTIMIZED_ASM > > OPTIMIZED_ASM_DESC=3D Use assembler optimizations > > ... > > > -.include <bsd.port.pre.mk> > > > +.include <bsd.port.options.mk> > > > =20 > > > .if ${ARCH} !=3D "i386" > > > WITHOUT_OPTIMIZED_ASM=3D yes > > > .endif > >=20 > > The above is uneeded as OPTIMIZED_ASM will never get defined with the _= arch > > syntax above. >=20 > Fixed all of these. Thanks for catching it and pointing me to the proper > way to do it! >=20 > I do have one question. In r307732 I had to change ${PERL} to just > 'perl' in the PERL_ARCHNAME!=3D line. This was working prior to the switch > to the new options so I'm curious if I did something wrong or uncovered > a bug? >=20 > -- WXS This is because ${PERL} is set by USE_PERL5, which is included after bsd.port.options.mk and you need it at the moment you parse the Makefile be= cause of: PERL_ARCHNAME!=3D ${PERL} -V:archname 2>/dev/null || true so what you have to do is either: =2Einclude <bsd.port.options.mk> Some checking =2Einclude <bsd.port.pre.mk> here is ${PERL} =2Einclude <bsd.port.post.mk> or directly =2Einclude <bsd.port.pre.mk> Some checking Here is ${PERL} =2Einclude <bsd.port.post.mk> Of course I haven't test the above regards, Bapt --TRYliJ5NKNqkz5bu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCx7hgACgkQ8kTtMUmk6EzsXgCeLQlBjRqsQ/ChZPnY1eMUmNoe VhYAoKrDfsIHdqmioWI3UuPgjnkyjmz0 =6mP7 -----END PGP SIGNATURE----- --TRYliJ5NKNqkz5bu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121125100824.GB33816>