From owner-freebsd-current@FreeBSD.ORG Wed May 4 10:45:03 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C013D106564A for ; Wed, 4 May 2011 10:45:03 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from fallbackmx06.syd.optusnet.com.au (fallbackmx06.syd.optusnet.com.au [211.29.132.8]) by mx1.freebsd.org (Postfix) with ESMTP id 4C1078FC08 for ; Wed, 4 May 2011 10:45:02 +0000 (UTC) Received: from mail14.syd.optusnet.com.au (mail14.syd.optusnet.com.au [211.29.132.195]) by fallbackmx06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p448M6J2012566 for ; Wed, 4 May 2011 18:22:06 +1000 Received: from server.vk2pj.dyndns.org (c220-239-116-103.belrs4.nsw.optusnet.com.au [220.239.116.103]) by mail14.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p448M33u016402 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 May 2011 18:22:04 +1000 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.4/8.14.4) with ESMTP id p448M3FC064806; Wed, 4 May 2011 18:22:03 +1000 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.4/8.14.4/Submit) id p448M2cx064805; Wed, 4 May 2011 18:22:02 +1000 (EST) (envelope-from peter) Date: Wed, 4 May 2011 18:22:02 +1000 From: Peter Jeremy To: Rick Macklem Message-ID: <20110504082202.GA64659@server.vk2pj.dyndns.org> References: <1088403240.552644.1303777994659.JavaMail.root@erie.cs.uoguelph.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <1088403240.552644.1303777994659.JavaMail.root@erie.cs.uoguelph.ca> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-current@freebsd.org Subject: Re: newnfs NFS client testing X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2011 10:45:03 -0000 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011-Apr-25 20:33:14 -0400, Rick Macklem wrote: >I believe that the new/experimental NFS client in head is now >compatible with the old/regular NFS client. Possibly even too compatible... Both the old and new NFS clients assume a 1:1 mapping between NFS error codes (NFSERR_* macros defined in ) and the E* macros in : In the old client, the NFS status is copied =66rom the RPC response by nfsclient/nfs_krpc.c:nfs_request(), returned and passed back up the call chain. In the new client, the status is copied from the RPC response into struct nfsrv_descript.nd_repstat by fs/nfs/nfs_commonkrpc.c:newnfs_request() and then moved into an error return in fs/nfsclient/nfs_clrpcops.c:nfsrpc_*(). This is not currently a problem but it would seem useful to include notes in and warning of this assumption in case of future changes. Note that both NFS servers do include code for error code mapping. --=20 Peter Jeremy --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iEYEARECAAYFAk3BDKoACgkQ/opHv/APuIdi6ACfV7oz27277ZxpRDKif44Nh3ly RR4AnRMUKwXPumMGDdTHsYPHNPT7UFsx =b0AG -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--