From owner-freebsd-python@FreeBSD.ORG  Sun Sep  2 10:03:12 2012
Return-Path: <owner-freebsd-python@FreeBSD.ORG>
Delivered-To: python@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 13C17106566C;
	Sun,  2 Sep 2012 10:03:12 +0000 (UTC)
	(envelope-from lwhsu.freebsd@gmail.com)
Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com
	[209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id A10378FC08;
	Sun,  2 Sep 2012 10:03:11 +0000 (UTC)
Received: by vbmv11 with SMTP id v11so5917291vbm.13
	for <multiple recipients>; Sun, 02 Sep 2012 03:03:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=0ABkBKUqYrLXWBQU9FGGCI0fO/yqHzzgr4MTZwvQ7h4=;
	b=OYryvxnLXQyOvQAm38auPMtefzKHppiEwpAyHgIvk042LudZq/aXu1knYbztfK6LaP
	Nzts3nl5O9AzgQKhR/spaRHQUkYRy5nIIDjW6EvXSPLBzbkRYLXiHfRDSqEv5az10iz3
	P8RBYpNDQxFh4Fwz39GEalsZYeoJ7Av4yQ9Yle98N0+wf5PG5buIm8FWBhULZSBhBWJn
	ibkmrkUp5WulYQcB0jLw6eDAFkftUmTkRnj63igHrdZNjLk8HUCAvaKEw6PDI0Mna3mD
	qwlkcIXvW6WApaBM04Uy7Ph/dMg8K9cLAPQU7qxyAlwkPn+cLEIz7rQwCaRIxjhu3fo0
	3Zcg==
MIME-Version: 1.0
Received: by 10.52.69.242 with SMTP id h18mr7806237vdu.54.1346580190544; Sun,
	02 Sep 2012 03:03:10 -0700 (PDT)
Sender: lwhsu.freebsd@gmail.com
Received: by 10.220.65.82 with HTTP; Sun, 2 Sep 2012 03:03:10 -0700 (PDT)
In-Reply-To: <50430B39.6040707@yandex.ru>
References: <50430B39.6040707@yandex.ru>
Date: Sun, 2 Sep 2012 18:03:10 +0800
X-Google-Sender-Auth: 9PGcP0NeBIln00Qp2tmZCABN9Qw
Message-ID: <CAKBkRUyV_CBTdY4xN7K_6PH4rQN80oU9+pQpscbmdLz-qAW_NQ@mail.gmail.com>
From: Li-Wen Hsu <lwhsu@FreeBSD.org>
To: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
Content-Type: text/plain; charset=UTF-8
Cc: python <python@freebsd.org>, portmgr@freebsd.org
Subject: Re: Simple change into Mk/bsd.python.mk
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>, 
	<mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>,
	<mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Sep 2012 10:03:12 -0000

On Sun, Sep 2, 2012 at 3:31 PM, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wrote:
> Hi,
>
> I'm preparing an update of www/plone and discovered thing that's need to be
> changed to make USE_ZOPE knob actually work. We do not define ZOPESKELDIR
> anymore, so the RUN_DEPENDS line should be fixed.
> While here, trim some leftover from py24/25 removal, that's now always true
> in current ports tree. Would you please approve this change?
>
> PS. It doesn't needed an exp-run because at the time there is no ports, that
> use USE_ZOPE.

Looks good to me, and if you don't mind, how about doing this:

    RUN_DEPENDS+=	${LOCALBASE}/bin/zopectl:${ZOPE_PORTSDIR}

in this way:

    RUN_DEPENDS+=	zope213>0:${ZOPE_PORTSDIR}

or even replace this:

    ZOPE_PORTSDIR=	${PORTSDIR}/www/zope213

with:

    ZOPE_DEPENDS=	zope213>0:${PORTSDIR}/www/zope213

and then, .if defined(USE_ZOPE) section can be written as:

    RUN_DEPENDS+=	${ZOPE_DEPENDS}

How do you think?

-- 
Li-Wen Hsu
http://lwhsu.org