Date: Sun, 23 Jul 2000 11:46:36 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: freebsd-stable@freebsd.org Subject: GENERIC needs some clean up.... Message-ID: <200007231846.LAA46031@gndrsh.dnsmgr.net>
next in thread | raw e-mail | index | archive | help
Just build a GENERIC kernel on 4.1-RC and noted the following compile warnings that really should be cleaned up: (Especially the ones about splx/splbio those just give me the utmost feeling of ``stable'' NOT!!) cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../dev/amr/amr.c ../../dev/amr/amr.c: In function `amr_free': ../../dev/amr/amr.c:171: warning: cast discards qualifiers from pointer target type ../../dev/amr/amr.c: In function `amr_periodic': ../../dev/amr/amr.c:696: warning: unused variable `i' ../../dev/amr/amr.c:696: warning: unused variable `s' ../../dev/amr/amr.c: In function `amr_start': ../../dev/amr/amr.c:1234: warning: passing arg 2 of `bcopy' discards qualifiers from pointer target type ../../dev/amr/amr.c: In function `amr_quartz_get_work': ../../dev/amr/amr.c:1534: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/amr/amr.c: In function `amr_std_get_work': ../../dev/amr/amr.c:1565: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/amr/amr.c: At top level: ../../dev/amr/amr.c:1031: warning: `amr_wait_command' defined but not used stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../dev/dpt/dpt_scsi.c ../../dev/dpt/dpt_scsi.c: In function `dpt_get_conf': ../../dev/dpt/dpt_scsi.c:496: warning: cast discards qualifiers from pointer target type ../../dev/dpt/dpt_scsi.c: In function `dpt_detect_cache': ../../dev/dpt/dpt_scsi.c:603: warning: cast discards qualifiers from pointer target type ../../dev/dpt/dpt_scsi.c: In function `dpt_init': ../../dev/dpt/dpt_scsi.c:1294: warning: cast discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../dev/ie/if_ie.c ../../dev/ie/if_ie.c: In function `ieget': ../../dev/ie/if_ie.c:1177: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1266: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1266: warning: passing arg 2 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1283: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1295: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c: In function `ie_readframe': ../../dev/ie/if_ie.c:1338: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c: In function `iestart': ../../dev/ie/if_ie.c:1437: warning: passing arg 2 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1451: warning: cast discards qualifiers from pointer target type ../../dev/ie/if_ie.c: In function `check_ie_present': ../../dev/ie/if_ie.c:1505: warning: passing arg 1 of pointer to function discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1514: warning: passing arg 1 of pointer to function discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1517: warning: passing arg 1 of pointer to function discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1542: warning: passing arg 1 of pointer to function discards qualifiers from pointer target type ../../dev/ie/if_ie.c: In function `command_and_wait': ../../dev/ie/if_ie.c:1799: warning: cast discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1815: warning: cast discards qualifiers from pointer target type ../../dev/ie/if_ie.c: In function `setup_rfa': ../../dev/ie/if_ie.c:1900: warning: passing arg 1 of pointer to function discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1924: warning: passing arg 1 of pointer to function discards qualifiers from pointer target type ../../dev/ie/if_ie.c: In function `mc_setup': ../../dev/ie/if_ie.c:1975: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c:1975: warning: passing arg 2 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c: In function `ieinit': ../../dev/ie/if_ie.c:2039: warning: passing arg 1 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c:2039: warning: passing arg 2 of `bcopy' discards qualifiers from pointer target type ../../dev/ie/if_ie.c:2088: warning: passing arg 1 of pointer to function discards qualifiers from pointer target type ../../dev/ie/if_ie.c:2089: warning: passing arg 1 of pointer to function discards qualifiers from pointer target type stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../dev/ppbus/ppi.c ../../dev/ppbus/ppi.c: In function `ppi_attach': ../../dev/ppbus/ppi.c:172: warning: unused variable `ppi' stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../dev/xe/if_xe.c ../../dev/xe/if_xe.c:1776: warning: `xe_compute_crc' defined but not used ../../dev/xe/if_xe.c:1811: warning: `xe_compute_hashbit' defined but not used cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../kern/init_sysent.c ../../kern/init_sysent.c:24: warning: cast discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../kern/kern_event.c ../../kern/kern_event.c: In function `kevent': ../../kern/kern_event.c:388: warning: passing arg 4 of `kqueue_scan' discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../kern/sys_generic.c ../../kern/sys_generic.c: In function `dofilewrite': ../../kern/sys_generic.c:356: warning: cast discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../kern/vfs_aio.c ../../kern/vfs_aio.c: In function `aio_process': ../../kern/vfs_aio.c:575: warning: cast discards qualifiers from pointer target type ../../kern/vfs_aio.c: In function `aio_qphysio': ../../kern/vfs_aio.c:1014: warning: cast discards qualifiers from pointer target type ../../kern/vfs_aio.c: At top level: ../../kern/vfs_aio.c:1426: warning: `aio_aqueue' defined but not used cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../net/if_gif.c ../../net/if_gif.c: In function `gif_encapcheck': ../../net/if_gif.c:203: warning: cast discards qualifiers from pointer target type ../../net/if_gif.c: In function `gif_ioctl': ../../net/if_gif.c:409: warning: `dst' might be used uninitialized in this function ../../net/if_gif.c:409: warning: `src' might be used uninitialized in this function cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../netinet/in_gif.c ../../netinet/in_gif.c: In function `gif_encapcheck4': ../../netinet/in_gif.c:334: warning: cast discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../netinet/in_proto.c ../../netinet/in_proto.c:163: warning: initialization from incompatible pointer type ../../netinet/in_proto.c:170: warning: initialization from incompatible pointer type ../../netinet/in_proto.c:212: warning: initialization from incompatible pointer type ../../netinet/in_proto.c:212: warning: initialization from incompatible pointer type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../netinet/ip_input.c ../../netinet/ip_input.c: In function `ip_input': ../../netinet/ip_input.c:660: warning: assignment from incompatible pointer type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../netinet/tcp_subr.c ../../netinet/tcp_subr.c: In function `tcp6_ctlinput': ../../netinet/tcp_subr.c:980: warning: `off' might be used uninitialized in this function cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../netinet6/in6_gif.c ../../netinet6/in6_gif.c: In function `gif_encapcheck6': ../../netinet6/in6_gif.c:320: warning: cast discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../netinet6/in6_ifattach.c ../../netinet6/in6_ifattach.c: In function `nigroup': ../../netinet6/in6_ifattach.c:621: warning: cast discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../netinet6/in6_pcb.c ../../netinet6/in6_pcb.c: In function `in6_pcbladdr': ../../netinet6/in6_pcb.c:273: warning: unused variable `pi' cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../netinet6/udp6_output.c ../../netinet6/udp6_output.c: In function `udp6_output': ../../netinet6/udp6_output.c:222: warning: address of register variable `m' requested cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../pci/amd.c ../../pci/amd.c:880: warning: `amd_timeout' defined but not used ../../pci/amd.c:838: warning: `amd_reset' defined but not used cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../pci/if_fxp.c ../../pci/if_fxp.c: In function `fxp_init': ../../pci/if_fxp.c:1448: warning: passing arg 2 of `bcopy' discards qualifiers from pointer target type ../../pci/if_fxp.c:1505: warning: passing arg 2 of `bcopy' discards qualifiers from pointer target type ../../pci/if_fxp.c: In function `fxp_mc_setup': ../../pci/if_fxp.c:2022: warning: passing arg 2 of `bcopy' discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../pci/ncr.c ../../pci/ncr.c: In function `ncr_log_hard_error': ../../pci/ncr.c:5331: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c: In function `ncr_exception': ../../pci/ncr.c:5468: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c: In function `ncr_int_ma': ../../pci/ncr.c:5771: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c:5775: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c:5799: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c:5806: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c:5814: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c:5819: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c:5829: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c:5833: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c: In function `ncr_regtest': ../../pci/ncr.c:6801: warning: cast discards qualifiers from pointer target type ../../pci/ncr.c:6802: warning: cast discards qualifiers from pointer target type cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no stdinc -I- -I. -I../.. -I../../../include -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../i386/i386/mem.c In file included from ../../i386/i386/mem.c:49: ../../sys/buf.h: In function `BUF_LOCK': ../../sys/buf.h:269: warning: implicit declaration of function `splbio' ../../sys/buf.h:276: warning: implicit declaration of function `splx' In file included from ../../i386/i386/mem.c:59: ../../sys/systm.h: At top level: ../../sys/systm.h:229: warning: type mismatch with previous implicit declaration ../../sys/buf.h:344: warning: previous implicit declaration of `splbio' ../../sys/systm.h:229: warning: `splbio' was previously implicitly declared to return `int' ../../sys/systm.h:245: warning: type mismatch with previous implicit declaration ../../sys/buf.h:346: warning: previous implicit declaration of `splx' ../../sys/systm.h:245: warning: `splx' was previously implicitly declared to return `int' -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007231846.LAA46031>