From owner-svn-src-all@FreeBSD.ORG Sun Jun 14 19:07:07 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 06D2F41F; Sun, 14 Jun 2015 19:07:07 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x232.google.com (mail-ig0-x232.google.com [IPv6:2607:f8b0:4001:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB46BCF5; Sun, 14 Jun 2015 19:07:06 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igbzc4 with SMTP id zc4so40983572igb.0; Sun, 14 Jun 2015 12:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=MXdSrXGCBO9lvDviDYzEviqT9tbLso0gsJn1t7ax2xw=; b=s/ezvG5gKT0/OUxjk14y8EJsilxbSFV/D8CBziUTKSRAOS31hbFDaucTJL2avAi+ij L7cra2tBslb2M7N4z9SAQy0JNIG2mKFMka42jXdWNNmuILlBKiB9PeYHFcZLn8eIbXET gtcs1gaCdjjVXStOf2/QoQuF86rm5CVovoyXMCt7vnrDk3crI1snRq6oGthiCx7p0NHW ubXDB9INFkn8ppqqtB8WnfoKGiYc6IMtV/dCSEwp31r4sDlECjle/4ifHoEoB/xSxT8t 31iZDfpZZZmbUgTv/i7wRBnduSYYdZeo9xHyVCNWIcVOgtAMAI3HI3InaVpnH5gOnxHg adeg== MIME-Version: 1.0 X-Received: by 10.50.79.228 with SMTP id m4mr16250270igx.6.1434308826244; Sun, 14 Jun 2015 12:07:06 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.38.133 with HTTP; Sun, 14 Jun 2015 12:07:06 -0700 (PDT) In-Reply-To: <887CD9C6-9807-48AF-A7A6-B33F91901414@gmail.com> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> <20150613024916.GA98218@troutmask.apl.washington.edu> <1434208622.1415.57.camel@freebsd.org> <557C661F.8080104@freebsd.org> <860017ED-D754-450C-865D-2D81A30C2212@xcllnt.net> <20150614100045.GF58397@zxy.spb.ru> <557D55CB.5050009@fastmail.net> <20150614171031.GA5857@troutmask.apl.washington.edu> <557DCBED.2010804@fastmail.net> <887CD9C6-9807-48AF-A7A6-B33F91901414@gmail.com> Date: Sun, 14 Jun 2015 12:07:06 -0700 X-Google-Sender-Auth: JEnTF_9lbwssCYyLCFlDqLbb2m8 Message-ID: Subject: Re: svn commit: r284198 - head/bin/ls From: Adrian Chadd To: Garrett Cooper Cc: Bruce Simpson , Steve Kargl , Slawa Olhovchenkov , Craig Rodrigues , Marcel Moolenaar , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Marcel Moolenaar , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Mailman-Approved-At: Sun, 14 Jun 2015 23:03:00 +0000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 19:07:07 -0000 On 14 June 2015 at 12:02, Garrett Cooper wrote: > >> On Jun 14, 2015, at 11:53, Adrian Chadd wrote: >> >> We have busybox already - it's called bsdbox, and it's in base, and >> we're already using it, and yes, it does pull in libxo. :) >> >> I'm not worried about the size increase of libxo. That's the wrong >> thing to focus on. If it gets much more bloated then I'll poke people >> with the big "what are you thinking" stick. The issues people have >> aren't size related, they're "this API needs improvement and we have >> bugs introduced into tools." >> >> I do like how zero percent of the comments are "hey, maybe we need >> unit tests that run these tools and ensure they output the right >> stuff." If this were ${WORK} and I were ${BOSS}, I'd have asked the >> libxo developers to include unit tests before/after for each thing >> they broke, so we don't have a repeat of this kind of thing. But, this >> apparently isn't ${WORK} and I definitely don't want to be anyones >> boss, so.. > > Ugh. I'll write the tests ;(... I'm not your boss! (but if you go and do it - great! thankyou! This is what should've been neckbearded, not the rest of the thread!) -a