From owner-freebsd-threads@FreeBSD.ORG  Fri Feb 18 20:51:11 2005
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9854016A4CF
	for <freebsd-threads@freebsd.org>;
	Fri, 18 Feb 2005 20:51:11 +0000 (GMT)
Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 30D7C43D1F
	for <freebsd-threads@freebsd.org>;
	Fri, 18 Feb 2005 20:51:11 +0000 (GMT)
	(envelope-from deischen@freebsd.org)
Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11])
	j1IKp8lN025926;	Fri, 18 Feb 2005 15:51:09 -0500 (EST)
Date: Fri, 18 Feb 2005 15:51:01 -0500 (EST)
From: Daniel Eischen <deischen@freebsd.org>
X-X-Sender: eischen@sea.ntplx.net
To: Craig Rodrigues <rodrigc@crodrigues.org>
In-Reply-To: <200502182040.j1IKeKG6019752@freefall.freebsd.org>
Message-ID: <Pine.GSO.4.43.0502181549040.16964-100000@sea.ntplx.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net)
cc: freebsd-threads@freebsd.org
Subject: Re: threads/76938: include/unistd.h: ttyname_r prototype missing
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Daniel Eischen <deischen@freebsd.org>
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Feb 2005 20:51:11 -0000

On Fri, 18 Feb 2005, Craig Rodrigues wrote:

> The following reply was made to PR threads/76938; it has been noted by GNATS.
>
> From: Craig Rodrigues <rodrigc@crodrigues.org>
> To: freebsd-gnats-submit@freebsd.org
> Cc: tmclaugh@sdf.lonestar.org, freebsd-standards@freebsd.org
> Subject: Re: threads/76938: include/unistd.h: ttyname_r prototype missing
> Date: Fri, 18 Feb 2005 15:30:45 -0500
>
>  The following patch exports ttyname_r() from <unistd.h> and makes it
>  conform to the Single Unix Specification:
>  http://www.opengroup.org/onlinepubs/009695399/functions/ttyname.html
>
>  Can someone with a commit bit take a look at it?

Style: all returns should be "return (foo)", not "return foo".

This may also cause an ABI change since ttyname_r use to
return (char *).  I'm not sure of the impact though 'cause
it was never in a header file.

-- 
DE