From owner-freebsd-multimedia  Thu Oct 22 02:54:15 1998
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id CAA15949
          for freebsd-multimedia-outgoing; Thu, 22 Oct 1998 02:54:15 -0700 (PDT)
          (envelope-from owner-freebsd-multimedia@FreeBSD.ORG)
Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5])
          by hub.freebsd.org (8.8.8/8.8.8) with SMTP id CAA15926
          for <multimedia@freebsd.org>; Thu, 22 Oct 1998 02:54:05 -0700 (PDT)
          (envelope-from luigi@labinfo.iet.unipi.it)
Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id IAA11737; Thu, 22 Oct 1998 08:56:10 +0100
From: Luigi Rizzo <luigi@labinfo.iet.unipi.it>
Message-Id: <199810220756.IAA11737@labinfo.iet.unipi.it>
Subject: Re: splay-0.8.2 & FreeBSD Audio Driver (980215)
To: nabe@ksj.mcu.or.jp (NABETANI Masaki)
Date: Thu, 22 Oct 1998 08:56:10 +0100 (MET)
Cc: junker@jazz.snu.ac.kr
In-Reply-To: <19981022181815P.nabe@ksj.mcu.or.jp> from "NABETANI Masaki" at Oct 22, 98 06:17:56 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-freebsd-multimedia@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

I got a report that the "pcm" driver does not start with small audio
files. This was due to a bug i introduced near the beginning of the
year to optimize performance :)

in any case, the fix is easy and i will commit it in the next hours on
-current (and for -stable, an update to the whole "pcm" code is
coming in): in dmabuf.c, function dsp_wrintr, change one line near
line 183 as follows:

         * check if we need to reprogram the DMA on the sound card.
         * This happens if the size has changed _and_ the new size
         * is smaller, or it matches the blocksize.
         */
-       if (l != b->dl && (l < b->dl || l == d->play_blocksize)){
+       if (l != b->dl && (b->dl == 0 || l < b->dl || l == d->play_blocksize)){
            /* for any reason, size has changed. Stop and restart */
            DEB(printf("wrintr: bsz change from %d to %d, rp %d rl %d\n",
                b->dl, l, b->rp, b->rl));



	cheers
	luigi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-multimedia" in the body of the message