From owner-freebsd-current@freebsd.org  Thu Aug 20 20:57:23 2015
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E4D99BF7D7
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Thu, 20 Aug 2015 20:57:23 +0000 (UTC)
 (envelope-from feld@FreeBSD.org)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 23BA71A85
 for <freebsd-current@freebsd.org>; Thu, 20 Aug 2015 20:57:22 +0000 (UTC)
 (envelope-from feld@FreeBSD.org)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 1742520B08
 for <freebsd-current@freebsd.org>; Thu, 20 Aug 2015 16:57:22 -0400 (EDT)
Received: from web3 ([10.202.2.213])
 by compute6.internal (MEProxy); Thu, 20 Aug 2015 16:57:22 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=pjiOULyc+DQckeU
 GiDJPE9t9gQg=; b=Y1bOe2+Kvi7zkObTqDFxmP37b+wDk78Dk79u4V/beYR51ZR
 2kF/V4ZfF31xelYRa74xua2n6F8oC9AqrYV6M5decQ0w0uALzAo2ucHk2WlFqmzW
 YrQa4NzviUFa/20Vp31LBcaxiReHHa9JbJHbYH3KEC/yJQMPPyvfNdfZ9Bbc=
Received: by web3.nyi.internal (Postfix, from userid 99)
 id E895310A65F; Thu, 20 Aug 2015 16:57:21 -0400 (EDT)
Message-Id: <1440104241.949504.361678217.77B8AB2E@webmail.messagingengine.com>
X-Sasl-Enc: 3Rwxxb96j1UbU9rQlxITCia1zKyAtJd3stfl1kRXaI/J 1440104241
From: Mark Felder <feld@FreeBSD.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: freebsd-current@freebsd.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
X-Mailer: MessagingEngine.com Webmail Interface - ajax-4fee8ba5
Subject: Re: pkg with an ssh repo crashes CURRENT
Date: Thu, 20 Aug 2015 15:57:21 -0500
In-Reply-To: <1440102370.941813.361650057.269DD227@webmail.messagingengine.com>
References: <1440014993.2793501.360634953.2FF3B076@webmail.messagingengine.com>
 <1440021176.3252738.360727753.7FEDAB82@webmail.messagingengine.com>
 <20150820115041.GU2072@kib.kiev.ua>
 <1440102370.941813.361650057.269DD227@webmail.messagingengine.com>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2015 20:57:23 -0000



On Thu, Aug 20, 2015, at 15:26, Mark Felder wrote:
> > 
> > diff --git a/sys/kern/kern_procctl.c b/sys/kern/kern_procctl.c
> > index d65ba5a..8ef72901 100644
> > --- a/sys/kern/kern_procctl.c
> > +++ b/sys/kern/kern_procctl.c
> > @@ -187,8 +187,6 @@ reap_status(struct thread *td, struct proc *p,
> >  		}
> >  	} else {
> >  		rs->rs_pid = -1;
> > -               KASSERT(LIST_EMPTY(&reap->p_reaplist), ("reap children
> > list"));
> > -               KASSERT(LIST_EMPTY(&reap->p_children), ("children
> > list"));
> >  	}
> >  	return (0);
> >  }
> 
> I'll try compiling a kernel with your patch and see what happens.
>

I can confirm that this fixes the crashes.