From owner-freebsd-python@freebsd.org Tue Feb 26 02:53:42 2019 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C51B915036FA for ; Tue, 26 Feb 2019 02:53:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4464392CAD for ; Tue, 26 Feb 2019 02:53:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id F1BA515036F8; Tue, 26 Feb 2019 02:53:41 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E01C115036F6 for ; Tue, 26 Feb 2019 02:53:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7DEFF92CA9 for ; Tue, 26 Feb 2019 02:53:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 8BC1B17BE5 for ; Tue, 26 Feb 2019 02:53:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x1Q2reIX057680 for ; Tue, 26 Feb 2019 02:53:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x1Q2reGd057679 for python@FreeBSD.org; Tue, 26 Feb 2019 02:53:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 236038] [NEW PORT] net-mgmt/py-nxapi_plumbing: Manage Cisco Nexus via JSON-RPC and XML Date: Tue, 26 Feb 2019 02:53:40 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 02:53:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236038 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|easy, patch, patch-ready |feature Status|New |Open --- Comment #1 from Kubilay Kocak --- Thanks John, Review items:=20 - Minor: Match a projects upstream description (setup.py:description) as closely as possible, with COMMENT (portlint) compliance changes where necessary. In this case "Library for managing Cisco devices through NX-API using XML or jsonrpc" - Projects setup.py:url is a 404, can you send an upstream issue/PR to corr= ect it - sdist includes tests and a test command (in tox.ini not shipped in sdist). Add TEST_DEPENDS (pytest) and a do(test) target for QA. The following should work: do-test: @cd ${WRKSRC}} && ${PYTHON_CMD} -m pytest -v -s test Would be great to confirm those tests pass as well --=20 You are receiving this mail because: You are on the CC list for the bug.=