Date: Tue, 6 Mar 2007 10:58:23 -0500 From: John Baldwin <jhb@freebsd.org> To: Paolo Pisati <piso@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 115367 for review Message-ID: <200703061058.24092.jhb@freebsd.org> In-Reply-To: <200703051726.26875.jhb@freebsd.org> References: <200703052146.l25LkM0V057457@repoman.freebsd.org> <200703051726.26875.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 05 March 2007 17:26, John Baldwin wrote: > On Monday 05 March 2007 16:46, Paolo Pisati wrote: > > http://perforce.freebsd.org/chv.cgi?CH=115367 > > > > Change 115367 by piso@piso_newluxor on 2007/03/05 21:45:54 > > > > o Wrap at 80 ata_pci_setup_intr(). > > o Style(9) a bit the indentation. > > You should really preserve the 4-space indent since that's what the rest of > sys/dev/ata/* uses, and consistency is preserved over a mixed bag. s/preserved/preferred/ > > Affected files ... > > > > .. //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#6 edit > > > > Differences ... > > > > ==== //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#6 (text+ko) ==== > > > > @@ -339,12 +339,12 @@ > > > > int > > ata_pci_setup_intr(device_t dev, device_t child, struct resource *irq, > > - int flags, driver_filter_t *filter, driver_intr_t *function, > > - void *argument, void **cookiep) > > + int flags, driver_filter_t *filter, driver_intr_t *function, > > + void *argument, void **cookiep) > > { > > if (ata_legacy(dev)) { > > - return BUS_SETUP_INTR(device_get_parent(dev), child, irq, > > - flags, filter, function, argument, cookiep); > > + return BUS_SETUP_INTR(device_get_parent(dev), child, irq, > > + flags, filter, function, argument, cookiep); > > } > > else { > > struct ata_pci_controller *controller = device_get_softc(dev); > > > > -- > John Baldwin > -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200703061058.24092.jhb>