From owner-freebsd-current@FreeBSD.ORG Fri Jan 18 15:11:03 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 78CE81E0; Fri, 18 Jan 2013 15:11:03 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bk0-f43.google.com (mail-bk0-f43.google.com [209.85.214.43]) by mx1.freebsd.org (Postfix) with ESMTP id A8992EC4; Fri, 18 Jan 2013 15:11:02 +0000 (UTC) Received: by mail-bk0-f43.google.com with SMTP id jf20so2064213bkc.2 for ; Fri, 18 Jan 2013 07:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=2DB98MW0QQecxFngd0FGNvThYTOxY/Z6IoNcXpONCco=; b=WK3fyWAVFQjNGo31ZcTceonDygQuPlaH+goyEOrZZPPPVp/Ls8C9oFVS+Fyw5wTety htJUdCF+J62N4dEk9JBVK9C1LSq6ofSraV4NM/TKCtWRhhggtglJFR8rRoTs9u7BrZiA OX53kCYqKlqoS2/G8HWd9gAlhcq/EJq7jV42HXX6trT3+BVMxH+4TfeKw7a9EoaMlZzr tS+8+Vlj92SAm6wCMjuOUQqAHdOwy6xNuvq3ctZWQJBMR1ZJ/aicVC+B1KXvTMPoVtOK t1swNXOou6IDgbTc3VoysHhu8kRPY11yG0DopvpE3W202DZyP74YZ4rNMoF0RipaITkO JjWw== X-Received: by 10.204.12.202 with SMTP id y10mr2716307bky.51.1358521861629; Fri, 18 Jan 2013 07:11:01 -0800 (PST) Received: from mavbook.mavhome.dp.ua (mavhome.mavhome.dp.ua. [213.227.240.37]) by mx.google.com with ESMTPS id q22sm4167884bkv.16.2013.01.18.07.10.59 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Jan 2013 07:11:00 -0800 (PST) Sender: Alexander Motin Message-ID: <50F96602.2090903@FreeBSD.org> Date: Fri, 18 Jan 2013 17:10:58 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Vitalij Satanivskij Subject: Re: panic after r244584 References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> <20130118133415.GA7189@hell.ukr.net> <20130118134954.GA7848@hell.ukr.net> In-Reply-To: <20130118134954.GA7848@hell.ukr.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jaakko Heinonen , Gleb Smirnoff , freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2013 15:11:03 -0000 On 18.01.2013 15:49, Vitalij Satanivskij wrote: > May be just do sanitizing for elmpriv->descr? > > something like change whitespace to "_" or just delete it? Yes, that is not difficult. The only question is how to stay consistent, compatible, user-readable. > Vitalij Satanivskij wrote: > VS> Jaakko Heinonen wrote: > VS> JH> On 2013-01-18, Alexander Motin wrote: > VS> JH> > > AM> > V> panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) > VS> JH> > VS> JH> > > AM> The panic is triggered by the check added by the recent r244584 change. > VS> JH> > > AM> The space in device name came from the enclosure device, and I guess it > VS> JH> > > AM> may be quite often situation. Using human readable name supposed to help > VS> JH> > > AM> system administrators, but with spaces banned that may be a problem. > VS> JH> > > > VS> JH> > > That's was not created by human, it was generated (I think so) by system. > VS> JH> > > VS> JH> > These strings are flashed into enclosure firmware by manufacturer. > VS> JH> > VS> JH> You can't rely on that any string can be safely used as a device name > VS> JH> even if spaces were allowed. Consider for example duplicate names and > VS> JH> "../". > VS> JH> > VS> JH> Where these names are generated? The original report didn't contain a > VS> JH> backtrace. > VS> > VS> Yes. No backtrace, because of switching off all debuging in kernel. > VS> > VS> For now I can't use that's server for testing, but there are another servers waiting for upgrade. > VS> > VS> I will try to reproduce problem with kernel debuger enabled. > VS> > VS> > VS> _______________________________________________ > VS> freebsd-current@freebsd.org mailing list > VS> http://lists.freebsd.org/mailman/listinfo/freebsd-current > VS> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > -- Alexander Motin