From owner-freebsd-current@FreeBSD.ORG Tue Jan 7 06:33:36 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 11CD9C7F; Tue, 7 Jan 2014 06:33:36 +0000 (UTC) Received: from mta04.bitpro.no (mta04.bitpro.no [92.42.64.203]) by mx1.freebsd.org (Postfix) with ESMTP id B41D8162F; Tue, 7 Jan 2014 06:33:35 +0000 (UTC) Received: from mail.lockless.no (mail.lockless.no [46.29.221.38]) by mta04.bitpro.no (Postfix) with ESMTPS id 4BCB110058C; Tue, 7 Jan 2014 07:33:33 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.lockless.no (Postfix) with ESMTP id 517058F71F3; Tue, 7 Jan 2014 07:34:19 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no Received: from mail.lockless.no ([127.0.0.1]) by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rpaMD89oZXCg; Tue, 7 Jan 2014 07:34:18 +0100 (CET) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) by mail.lockless.no (Postfix) with ESMTPSA id 699F28F707E; Tue, 7 Jan 2014 07:34:18 +0100 (CET) Message-ID: <52CBA003.2080100@bitfrost.no> Date: Tue, 07 Jan 2014 07:34:43 +0100 From: Hans Petter Selasky Organization: Bitfrost A/S User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: huanghwh@gmail.com Subject: Re: Install 10.0-RC3 on MacBookPro Late 2013 References: <52CA56E5.8030101@bitfrost.no> <52CA6E3F.9000301@bitfrost.no> <52CA7CE0.7070202@bitfrost.no> <52CACBB8.1020905@bitfrost.no> <52CB2591.9050401@bitfrost.no> In-Reply-To: Content-Type: multipart/mixed; boundary="------------070109040904060903090909" Cc: Adrian Chadd , freebsd-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 06:33:36 -0000 This is a multi-part message in MIME format. --------------070109040904060903090909 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 01/07/14 03:30, Huang Wen Hui wrote: > Hans, > > This wild guess do NOT works. > I binary sect xhci.c in SVN, found that *r245732 > ** > introduce the bug.* > > revert to r345731 fixed this USB problem in 9.2R > > I also copy xhci_interrupt(struct xhci_softc *sc) from 9.1R to CURRENT, > CURRENT also works! > > Cheers, > Huang Wen Hui. Hi, We need to take this step by step. Thanks for tracing this down! Can you test the attached patch towards -current. Thank you! --HPS --------------070109040904060903090909 Content-Type: text/x-patch; name="xhci.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xhci.diff" === ./xhci.c ================================================================== --- ./xhci.c (revision 260319) +++ ./xhci.c (local) @@ -1582,8 +1582,6 @@ USB_BUS_LOCK(&sc->sc_bus); status = XREAD4(sc, oper, XHCI_USBSTS); - if (status == 0) - goto done; /* acknowledge interrupts */ @@ -1591,10 +1589,8 @@ DPRINTFN(16, "real interrupt (status=0x%08x)\n", status); - if (status & XHCI_STS_EINT) { - /* check for event(s) */ - xhci_interrupt_poll(sc); - } + /* check for event(s) */ + xhci_interrupt_poll(sc); if (status & (XHCI_STS_PCD | XHCI_STS_HCH | XHCI_STS_HSE | XHCI_STS_HCE)) { @@ -1618,7 +1614,6 @@ __FUNCTION__); } } -done: USB_BUS_UNLOCK(&sc->sc_bus); } --------------070109040904060903090909--