From owner-cvs-all  Tue Oct  3 10:17:16 2000
Delivered-To: cvs-all@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP
	id E71E037B66D; Tue,  3 Oct 2000 10:17:10 -0700 (PDT)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.11.0/8.11.0) with ESMTP id e93HH9M10297;
	Tue, 3 Oct 2000 11:17:09 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id LAA27389; Tue, 3 Oct 2000 11:17:08 -0600 (MDT)
Message-Id: <200010031717.LAA27389@harmony.village.org>
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Subject: Re: cvs commit: ports/net/socks5/patches patch-as 
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-reply-to: Your message of "Tue, 03 Oct 2000 11:40:22 EDT."
		<200010031540.LAA40689@khavrinen.lcs.mit.edu> 
References: <200010031540.LAA40689@khavrinen.lcs.mit.edu>  <200010030328.UAA25300@freefall.freebsd.org> 
Date: Tue, 03 Oct 2000 11:17:08 -0600
From: Warner Losh <imp@village.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <200010031540.LAA40689@khavrinen.lcs.mit.edu> Garrett Wollman writes:
: <<On Mon, 2 Oct 2000 20:28:46 -0700 (PDT), Warner Losh <imp@FreeBSD.org> said:
: 
: >   A more proper fix might be to fix Signal to have multi-shot signals,
: 
: It does, unless one of the SysV-compatibility flags is enabled in
: sigaction().

Signal() is a socks function, not the signal(3) we all know and love.
Signal does:
#ifdef SA_RESETHAND
    sa.sa_flags |= SA_RESETHAND;
#endif
which is what causes this behavior.  That's what sucks and should
likely be fixed.

A random nuron fired this morning and I went off and looked at their
patches page.  They fixed this in a different way than I did by
patching Signal() so that doesn't compile this in when they are in
their server, which I think is an uglier patch than what I did...  But
I'll see about getting that into the port and removing my patch.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message