From owner-freebsd-current@FreeBSD.ORG Fri Feb 6 08:54:38 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39B6016A4D2 for ; Fri, 6 Feb 2004 08:54:38 -0800 (PST) Received: from phantom.cris.net (phantom.cris.net [212.110.130.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9600243D2F for ; Fri, 6 Feb 2004 08:54:32 -0800 (PST) (envelope-from ru@FreeBSD.org.ua) Received: from phantom.cris.net (ru@localhost [127.0.0.1]) by phantom.cris.net (8.12.10/8.12.10) with ESMTP id i16GtVoh032477; Fri, 6 Feb 2004 18:55:31 +0200 (EET) (envelope-from ru@FreeBSD.org.ua) Received: (from ru@localhost) by phantom.cris.net (8.12.10/8.12.10/Submit) id i16GtVw6032472; Fri, 6 Feb 2004 18:55:31 +0200 (EET) (envelope-from ru) Date: Fri, 6 Feb 2004 18:55:30 +0200 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20040206165530.GG29305@FreeBSD.org.ua> References: <20040205091634.GC13932@FreeBSD.org.ua> <20040206012805.N8113@gamplex.bde.org> <20040205151425.GA18523@FreeBSD.org.ua> <20040206030956.F11456@gamplex.bde.org> <20040205190906.GD20227@FreeBSD.org.ua> <20040206153150.J14249@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VbfcI4OLZ4XW0yH2" Content-Disposition: inline In-Reply-To: <20040206153150.J14249@gamplex.bde.org> User-Agent: Mutt/1.5.5.1i cc: current@FreeBSD.org Subject: Re: Very long SRCS list with unusually long src/ prefix X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2004 16:54:38 -0000 --VbfcI4OLZ4XW0yH2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 06, 2004 at 03:52:44PM +1100, Bruce Evans wrote: [...] > > > That is slow too. I get 12.12 seconds with make, 2.36 with make -j1, > > > 1.37 with a shell loop and bash-1, 1.35 with a shell loop and /bin/sh, > > > and 0.0042 with jot 1000 >/dev/null. > > > > > Shell loops aren't an option here. I realize that we loose speed here, > > but we gain a feature. >=20 > Ah, but I always choose speed over features (except reverse creeping ones= ) :-). >=20 Sorry, I meant "but we fix a bug". > 0.18 seconds in bin/cat is huge. >=20 Yep, given that most people don't need it. Do you have an idea of how to do it properly, as even making heuristics on the number of source files to select the "make depend" algorithm doesn't seem right to me? Perhaps in the meantime, I should just add an undocumented knob, _SAFE_MKDEP (please suggest a better name), and provide both versions of "make depend", with the old version as default? > A null "make depend" is when .depend is not stale (an maybe all > relevant disk blocks are cached). >=20 A null "make depend" is not affected by this change. > > Yes, but ``grep ^MKDEPCMD bsd.dep.mk'' to see what I'm talking > > about. >=20 > I know. MKDEPCMD should be put in the environment before execing > xargs instead of after to avoid the env process. It seems to the > only thing that needs to be put in the environment here. See the > similar cleanup in kern.post.mk. >=20 Please see my other message with the patch that splits environment variables from command name. Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --VbfcI4OLZ4XW0yH2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAI8cCUkv4P6juNwoRAmHeAJ498dPUExMEr88G6Eh5JREA8aBeQACfTdtQ r+WL4MIs3+rEEzQUoDDMkWs= =5NF+ -----END PGP SIGNATURE----- --VbfcI4OLZ4XW0yH2--