From owner-freebsd-current Fri Jul 2 17:11:33 1999 Delivered-To: freebsd-current@freebsd.org Received: from penelope.skunk.org (unknown [208.133.204.51]) by hub.freebsd.org (Postfix) with ESMTP id 1A1B515080 for ; Fri, 2 Jul 1999 17:11:29 -0700 (PDT) (envelope-from ben@penelope.skunk.org) Received: from localhost (ben@localhost) by penelope.skunk.org (8.9.3/8.9.3) with ESMTP id AAA27899; Sat, 3 Jul 1999 00:09:53 GMT Date: Sat, 3 Jul 1999 00:09:53 +0000 (GMT) From: Ben Rosengart To: Greg Lehey Cc: "Brian F. Feldman" , current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) In-Reply-To: <19990703093223.V87392@freebie.lemis.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 3 Jul 1999, Greg Lehey wrote: > I personally think that, in such a case, you'd be justified to commit > it as a temporary measure. Due to the difference in time zones, this > has hit people while I've been asleep. That doesn't mean the commit > would stay, of course, but at least it would save people unnecessary > pain. Note, of course, that I have now committed the correct file, > which I had forgotten last night. > > What do you others think? Was the fix that wasn't yours correct? 'Cause I'd rather have code that doesn't compile than code that compiles but is subtly wrong. -- Ben UNIX Systems Engineer, Skunk Group StarMedia Network, Inc. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message