From owner-freebsd-arm@FreeBSD.ORG Mon Dec 3 13:31:53 2007 Return-Path: Delivered-To: freebsd-arm@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD4E216A421 for ; Mon, 3 Dec 2007 13:31:53 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from mail.semihalf.com (mail.semihalf.com [83.15.139.206]) by mx1.freebsd.org (Postfix) with ESMTP id 0EE2F13C4CC for ; Mon, 3 Dec 2007 13:31:53 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from localhost (unknown [127.0.0.1]) by mail.semihalf.com (Postfix) with ESMTP id 68CC21443D; Mon, 3 Dec 2007 14:34:15 +0100 (CET) Received: from mail.semihalf.com ([127.0.0.1]) by localhost (mail.semihalf.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18946-02; Mon, 3 Dec 2007 14:34:13 +0100 (CET) Message-ID: <47540545.6020407@semihalf.com> Date: Mon, 03 Dec 2007 14:31:49 +0100 From: Rafal Jaworowski MIME-Version: 1.0 To: "M. Warner Losh" References: <20071202140920.GA40640@ci0.org> <20071202.072138.1723236577.imp@bsdimp.com> <4752C2A0.9010604@semihalf.com> <20071202.074803.-1625880187.imp@bsdimp.com> In-Reply-To: <20071202.074803.-1625880187.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at semihalf.com Cc: freebsd-arm@FreeBSD.ORG Subject: Re: ARM arch subdir cleanups X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2007 13:31:53 -0000 M. Warner Losh wrote: > : Are your OBIO cleanups available somewhere? Are you going to finish these (so > : as not to overlap the work...)? > > What I've done to date is available in the p4 branch "arm-devel" and > are in the form of a set of routines in subr_obio.c. They likely need > to be enhanced and generalized a little (I just converted at91 to use > them, nothing else). I had hoped to be able to come up with something > that could also be merged into RELENG_7 as an optional feature to keep > maintenance costs down for things MFC'd. I'll have a look at your changes and try to come up with something generic for all OBIO incarnations; it's good you reworked the at91 as it seemed to me mostly divergent from what other OBIOs (Xscales mainly) look like. > : > The other thing that I'd like to see is a better defined board/cpu > : > initialization sequence. Or to make better use of the one that's > : > defined now and document it better. I made some bad choices, in > : > hindsight, for the at91rm9200 port that are only now becoming > : > apparent. > : > > : > : Yes, this is a valid point. As we already talked I keep this in mind while > : fleshing out the Orion port, but it'll make more sense for me to return to > : such refactoring in a second spin, after we have basic functionality in operation. > > One thing that might help is better documentation in this area. Had > my professional life not taken an unexpected turn recently, I had > planned on getting some time to document the conventions and try to > move all the arm subports into compliance with that vision. I was > then hoping to use that experience to define a cleanup, etc. However, Could you perhaps be able to share some notes on the most important items from that envisioned changes/refactoring? Rafal