From owner-freebsd-audit Thu May 31 11:30:36 2001 Delivered-To: freebsd-audit@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id D6C0B37B422; Thu, 31 May 2001 11:30:33 -0700 (PDT) (envelope-from mike@q9media.com) Received: from [192.168.1.10] (vega.tct.net [216.94.230.13]) by coffee.q9media.com (8.11.2/8.11.2) with ESMTP id f4VIdBL87734; Thu, 31 May 2001 14:39:12 -0400 (EDT) (envelope-from mike@q9media.com) User-Agent: Microsoft-Outlook-Express-Macintosh-Edition/5.02.2022 Date: Thu, 31 May 2001 14:30:21 -0400 Subject: Re: whois(1) patch From: Mike Barcroft To: Mike Heffner Cc: , Message-ID: In-Reply-To: Mime-version: 1.0 Organization: q9 media Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 5/30/01 10:34 PM, Mike Heffner at mheffner@novacoxmail.com wrote: > On 29-May-2001 Mike Barcroft wrote: > | > | Please review the patch at the following URL: > | http://testbed.q9media.net/freebsd/whois.patch > | > | > | It does the following: > | > | o Silence warnings and set WARNS=2 > | o Fix two memory leaks > | o asprint -> strdup where appropriate > | o calloc/strcpy/strcat -> aprintf > | o Convert to ANSI C to avoid having to prototype main() > > You don't need the space between (void) and asprintf(). Also, I think dd had a > patch for gcc to quiet the warning about main() not having a prototype, so I > don't know if the ANSI-fication is truly needed. Otherwise, looks alright ;) Oops, how'd that space sneak in there. I've removed the space from the patch. I must be spending too much time looking at sendmail's source. :) I originally made the ANSI C change to silence a warning, but is there any reason not to bring the code up to ANSI C spec? Is it likely that anyone will need to compile whois with a K&R compiler? Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message