From owner-freebsd-current@FreeBSD.ORG Sat Apr 18 15:36:07 2015 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2656AD2B; Sat, 18 Apr 2015 15:36:07 +0000 (UTC) Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DF6ABC6A; Sat, 18 Apr 2015 15:36:06 +0000 (UTC) Received: by oiko83 with SMTP id o83so95783001oik.1; Sat, 18 Apr 2015 08:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=sj5E38ns/0vJqa29AKzhnSPxkNazP3jyWztIVQFMMcg=; b=NmAelFBSo2bAtGtSFfOYGccImUoE/Mvgx7Yw8C0X70uH0Xlr1raoKeO9cyWI2NNael yGG8MlnB7fu7lC0xI8vuQtbixh3CwPXiNd3c9LcXCz4fYwpDkuCMdWm2YR29QzZCpjbT ditrPFpaNnyqEh5CgEsximXPx3/zOs+ex1GJMbweOw7AZDk+q4S6WG6rosDoMyO/Q9+x D/kwBOisJrViQXEP37VZPwnU0QFTY6oD6a/dv9nJPZ8Twp50y+TFn5nI9qbwOMfxC1lA 1nB2hVYzxQ+vKsmUkcWgcBG1vCkTD14VlEdgxjPVLUpwDH1NJzHjUVQU8N8UM8sq7umo drTA== MIME-Version: 1.0 X-Received: by 10.60.103.70 with SMTP id fu6mr7532056oeb.27.1429371365686; Sat, 18 Apr 2015 08:36:05 -0700 (PDT) Received: by 10.202.134.70 with HTTP; Sat, 18 Apr 2015 08:36:05 -0700 (PDT) Received: by 10.202.134.70 with HTTP; Sat, 18 Apr 2015 08:36:05 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: <20150418151702.GB36163@albert.catwhisker.org> References: <20150418151702.GB36163@albert.catwhisker.org> Date: Sat, 18 Apr 2015 23:36:05 +0800 Message-ID: Subject: Re: Fix for r281680 -- broke i386 world From: Marcelo Araujo To: current@freebsd.org, Takanori Watanabe , David Wolfskill Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2015 15:36:07 -0000 Hi, Saw your patch, why %ju and not %llx as the output shows? Best, Head/amd64 @ r281689 built OK, but my i386 build failed: ... --- usr.sbin.all__D --- --- all_subdir_bluetooth --- /usr/src/usr.sbin/bluetooth/hccontrol/le.c:236:4: error: format specifies type 'unsigned long' but the argument has type 'u_int64_t' (aka 'unsigned long long') [-Werror,-Wformat] rp.le_features); ^~~~~~~~~~~~~~ /usr/src/usr.sbin/bluetooth/hccontrol/le.c:253:49: error: format specifies type 'unsigned long' but the argument has type 'u_int64_t' (aka 'unsigned long long') [-Werror,-Wformat] printf("LE_STATUS: %d %d %lx\n", e, rp.status, rp.le_status); ~~~ ^~~~~~~~~~~~ %llx 2 errors generated. .... The attached patch allows i386 to build, and I then tested to verify that amd64 still built. (I don't have Bluetooth devices, so I cannot test its operation.) Peace, david -- David H. Wolfskill david@catwhisker.org Those who murder in the name of God or prophet are blasphemous cowards. See http://www.catwhisker.org/~david/publickey.gpg for my public key.