From owner-freebsd-rc@FreeBSD.ORG  Tue Oct 10 11:41:09 2006
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@hub.freebsd.org
Delivered-To: freebsd-rc@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4487016A412
	for <freebsd-rc@hub.freebsd.org>; Tue, 10 Oct 2006 11:41:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CF61E43DBA
	for <freebsd-rc@hub.freebsd.org>; Tue, 10 Oct 2006 11:40:28 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9ABeRLU018687
	for <freebsd-rc@freefall.freebsd.org>; Tue, 10 Oct 2006 11:40:27 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9ABeRwZ018684;
	Tue, 10 Oct 2006 11:40:27 GMT (envelope-from gnats)
Date: Tue, 10 Oct 2006 11:40:27 GMT
Message-Id: <200610101140.k9ABeRwZ018684@freefall.freebsd.org>
To: freebsd-rc@FreeBSD.org
From: Yar Tikhiy <yar@comp.chem.msu.su>
Cc: 
Subject: Re: bin/104044: [patch] rc.d/cleartmp works incorrectly
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Yar Tikhiy <yar@comp.chem.msu.su>
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Oct 2006 11:41:09 -0000

The following reply was made to PR bin/104044; it has been noted by GNATS.

From: Yar Tikhiy <yar@comp.chem.msu.su>
To: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
Cc: Florent Thoumie <flz@xbsd.org>, bug-followup@freebsd.org
Subject: Re: bin/104044: [patch] rc.d/cleartmp works incorrectly
Date: Tue, 10 Oct 2006 15:31:35 +0400

 On Tue, Oct 10, 2006 at 02:34:43PM +0400, Yar Tikhiy wrote:
 > 
 > > 2.	Ignore error code from rm and always run find, that is
 > > 	use "rm ... ; find ..." instead of "rm ... && find ...":
 > > 	one can create many files with long names and rm will not
 > > 	be called because of "Argument list too long" error, so
 > > 	find should do all of the work.
 > 
 > By the way, did you consider omitting the first rm at all and just
 > using "find ... -print0 | xargs -0 rm -rf" ?  The first rm can be
 > an optimization as long as we use find with -exec.  OTOH, xargs -0
 > would buy us the same performance and robustness without hacks.
 > Both find and xargs should be available to cleartmp.  Here's the
 > code.  Note "type -d" omitted.
 > 
 > 	if checkyesno ${rcvar1}; then
 > 		# This is not needed with mfs /tmp, but doesn't hurt anything.
 > 		echo "Clearing /tmp."
 > 		find -x /tmp/. ! -name . \
 > 			! \( -name lost+found -type d -user root \) \
 > 			! \( \( -name quota.user -or -name quota.group \) \
 > 				-type f -user root \) \
 > 			-prune -print0 | xargs -0 rm -rf
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 	elif ...
 
 It seems we can use just "-delete" here.  If run as root, find
 deletes entries with funny permissions or flags as well as rm does.
 BTW, find will descend into lost+found and delete its contents in
 both cases (rm w/ -prune, or -delete), which is good IMHO.
 
 -- 
 Yar