From owner-freebsd-bugs Thu Oct 5 2:57:30 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id D8E0437B502; Thu, 5 Oct 2000 02:57:26 -0700 (PDT) Received: from turing.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 5 Oct 2000 10:57:21 +0100 (BST) Date: Thu, 5 Oct 2000 10:57:20 +0100 From: David Malone To: dwmalone@FreeBSD.org Cc: freebsd-bugs@FreeBSD.org, bob@immure.com Subject: Re: misc/21204: bit_ffc and bit_ffs macros in bitstring.h test 1 byte too many. Message-ID: <20001005105720.A1562@turing.maths.tcd.ie> References: <200010022119.OAA17662@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.2i In-Reply-To: <200010022119.OAA17662@freefall.freebsd.org>; from dwmalone@FreeBSD.org on Mon, Oct 02, 2000 at 02:19:13PM -0700 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Mon, Oct 02, 2000 at 02:19:13PM -0700, dwmalone@FreeBSD.org wrote: > I've looked at the patch and it seems correct. Anyone want to review it for > me? As bde pointed out, the patch is not correct. Bitstring.h also has other problems. If no one objects I'll sync our version with NetBSD's version. They have already fixed most of the issues with the code. David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message