Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Feb 2008 23:59:19 +0000
From:      Rui Paulo <rpaulo@FreeBSD.org>
To:        Andriy Gapon <avg@icyb.net.ua>
Cc:        freebsd-acpi@freebsd.org, njl@freebsd.org
Subject:   Re: probable typo in acpi_cpu.c
Message-ID:  <C2E075B0-4092-40A4-B054-DB722F3E7AC1@FreeBSD.org>
In-Reply-To: <47B0BCA2.6040204@icyb.net.ua>
References:  <47B0BCA2.6040204@icyb.net.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

On Feb 11, 2008, at 9:22 PM, Andriy Gapon wrote:

>
> There is probably a typo in acpi_cpu.c, function acpi_cpu_startup:
> 	    if (cpu_quirks && CPU_QUIRK_NO_C3) { <----- here
> 		sc->cpu_cx_count = sc->cpu_non_c3 + 1;
> 	    }
>
> Not sure how that affects the logic though.

You are right. This means that the C3 state will still be available on  
systems like those based on PIIX4.

Nate, could you please commit a fix for it?

Regards.
--
Rui Paulo




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C2E075B0-4092-40A4-B054-DB722F3E7AC1>