From owner-svn-ports-all@freebsd.org Fri Mar 8 18:50:45 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E72FE1525D36; Fri, 8 Mar 2019 18:50:44 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 900D2867F9; Fri, 8 Mar 2019 18:50:44 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 7FE84142DE; Fri, 8 Mar 2019 18:50:44 +0000 (UTC) From: Jan Beich To: Brooks Davis Cc: Adam Weinberger , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r495007 - in head/devel: . llvm References: <201903080040.x280ewF0084625@repo.freebsd.org> <20190308180601.GH78397@spindle.one-eyed-alien.net> Date: Fri, 08 Mar 2019 19:50:39 +0100 In-Reply-To: <20190308180601.GH78397@spindle.one-eyed-alien.net> (Brooks Davis's message of "Fri, 8 Mar 2019 18:06:01 +0000") Message-ID: <4l8d-9p4w-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 900D2867F9 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.92 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.92)[-0.923,0]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 18:50:45 -0000 Brooks Davis writes: > On Fri, Mar 08, 2019 at 06:03:55AM -0700, Adam Weinberger wrote: > >> On Thu, Mar 7, 2019 at 5:41 PM Brooks Davis wrote: >> > >> > It is intended for use by users and should not be a port build dependency. >> >> Perhaps a comment near the top of the Makefile about this could be >> helpful. Right now there's nothing in the Makefile or pkg-descr to >> inform future porters of this important implementation detail. > > What I'd really like is a way to declare a port as ineligible to be a > dependency. Like the following? $ DEVELOPER=1 make check-sanity /!\ foo-0.1: Makefile errors /!\ devel/llvm in BUILD_DEPENDS is unsupported, please use devel/llvm60 instead *** Error code 1 Stop. make: stopped in /usr/ports/misc/foo --- Mk/bsd.sanity.mk.orig +++ Mk/bsd.sanity.mk @@ -70,6 +70,14 @@ DEV_WARNING+= "Not validating first entry in CATEGORIES due to being outside of DEV_ERROR+= "USE_PERL5=yes is unsupported, please use USES=perl5 instead" .endif +.if !empty(BUILD_DEPENDS:M*devel/llvm) +DEV_ERROR+= "devel/llvm in BUILD_DEPENDS is unsupported, please use devel/llvm${LLVM_DEFAULT} instead" +.endif + +.if !empty(BUILD_DEPENDS:M*lang/gcc) +DEV_ERROR+= "lang/gcc in BUILD_DEPENDS is unsupported, please use USE_GCC=yes instead" +.endif + .if !empty(LIB_DEPENDS:M*/../*) DEV_ERROR+= "LIB_DEPENDS contains unsupported relative path to dependency" .endif