Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Oct 2007 16:16:39 GMT
From:      "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/117631: benchmarks/siege: [PATCH]: Unbreak on 7.x+
Message-ID:  <200710291616.l9TGGdBI078482@www.freebsd.org>
Resent-Message-ID: <200710291620.l9TGK2ZG009312@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         117631
>Category:       ports
>Synopsis:       benchmarks/siege: [PATCH]: Unbreak on 7.x+
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 29 16:20:02 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Philip M. Gollucci
>Release:        FreeBSD 7.0-current
>Organization:
Riderway Inc.
>Environment:
FreeBSD philip.hq.rws 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Thu Jul 26 16:44:37 EDT 2007     root@philip.office.rws:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
-ldl no longer exists on 7.x+

Removed this from $LIBS in the configure script.

dl was for dlopen which is part of libc on freebsd.

>How-To-Repeat:

>Fix:
Apply patch 
note new file (files/patch-configure)


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/benchmarks/siege/Makefile,v
retrieving revision 1.26
diff -u -r1.26 Makefile
--- Makefile	5 Sep 2007 14:37:50 -0000	1.26
+++ Makefile	29 Oct 2007 16:14:16 -0000
@@ -24,10 +24,6 @@
 
 .include <bsd.port.pre.mk>
 
-.if (${OSVERSION} >= 700000)
-BROKEN=		Does not compile on 7.X
-.endif
-
 do-install:
 	@${INSTALL_PROGRAM} ${WRKSRC}/src/siege ${PREFIX}/bin
 	@${INSTALL_SCRIPT} ${WRKSRC}/utils/bombardment ${PREFIX}/bin
cvs diff: files/patch-configure is a new entry, no comparison available
--- /dev/null	2007-10-29 12:11:02.000000000 -0400
+++ files/patch-configure	2007-10-29 12:10:14.000000000 -0400
@@ -0,0 +1,65 @@
+--- ./configure.orig	2007-10-29 12:09:17.000000000 -0400
++++ ./configure	2007-10-29 12:09:50.000000000 -0400
+@@ -9533,7 +9533,7 @@
+   echo $ECHO_N "(cached) $ECHO_C" >&6
+ else
+   ac_check_lib_save_LIBS=$LIBS
+-LIBS="-ldl  $LIBS"
++LIBS="$LIBS"
+ cat >conftest.$ac_ext <<_ACEOF
+ /* confdefs.h.  */
+ _ACEOF
+@@ -9592,7 +9592,7 @@
+ echo "$as_me:$LINENO: result: $ac_cv_lib_dl_dlopen" >&5
+ echo "${ECHO_T}$ac_cv_lib_dl_dlopen" >&6
+ if test $ac_cv_lib_dl_dlopen = yes; then
+-  lt_cv_dlopen="dlopen" lt_cv_dlopen_libs="-ldl"
++  lt_cv_dlopen="dlopen" lt_cv_dlopen_libs=""
+ else
+   echo "$as_me:$LINENO: checking for dlopen in -lsvld" >&5
+ echo $ECHO_N "checking for dlopen in -lsvld... $ECHO_C" >&6
+@@ -13314,7 +13314,7 @@
+   echo $ECHO_N "(cached) $ECHO_C" >&6
+ else
+   ac_check_lib_save_LIBS=$LIBS
+-LIBS="-ldl  $LIBS"
++LIBS="$LIBS"
+ cat >conftest.$ac_ext <<_ACEOF
+ /* confdefs.h.  */
+ _ACEOF
+@@ -13373,7 +13373,7 @@
+ echo "$as_me:$LINENO: result: $ac_cv_lib_dl_dlopen" >&5
+ echo "${ECHO_T}$ac_cv_lib_dl_dlopen" >&6
+ if test $ac_cv_lib_dl_dlopen = yes; then
+-  lt_cv_dlopen="dlopen" lt_cv_dlopen_libs="-ldl"
++  lt_cv_dlopen="dlopen" lt_cv_dlopen_libs=""
+ else
+   echo "$as_me:$LINENO: checking for dlopen in -lsvld" >&5
+ echo $ECHO_N "checking for dlopen in -lsvld... $ECHO_C" >&6
+@@ -19049,7 +19049,7 @@
+   echo $ECHO_N "(cached) $ECHO_C" >&6
+ else
+   ac_check_lib_save_LIBS=$LIBS
+-LIBS="-ldl  $LIBS"
++LIBS="$LIBS"
+ cat >conftest.$ac_ext <<_ACEOF
+ /* confdefs.h.  */
+ _ACEOF
+@@ -19108,7 +19108,7 @@
+ echo "$as_me:$LINENO: result: $ac_cv_lib_dl_dlopen" >&5
+ echo "${ECHO_T}$ac_cv_lib_dl_dlopen" >&6
+ if test $ac_cv_lib_dl_dlopen = yes; then
+-  lt_cv_dlopen="dlopen" lt_cv_dlopen_libs="-ldl"
++  lt_cv_dlopen="dlopen" lt_cv_dlopen_libs=""
+ else
+   echo "$as_me:$LINENO: checking for dlopen in -lsvld" >&5
+ echo $ECHO_N "checking for dlopen in -lsvld... $ECHO_C" >&6
+@@ -20809,7 +20809,7 @@
+ 
+ echo "$as_me:$LINENO: result: no" >&5
+ echo "${ECHO_T}no" >&6;
+-  LDL=-ldl
++  LDL=
+   LIBS=$olibs
+ fi
+ rm -f conftest.err conftest.$ac_objext \


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710291616.l9TGGdBI078482>