From owner-freebsd-current  Thu Nov 29 23:39:53 2001
Delivered-To: freebsd-current@freebsd.org
Received: from winston.freebsd.org (adsl-64-173-15-98.dsl.sntc01.pacbell.net [64.173.15.98])
	by hub.freebsd.org (Postfix) with ESMTP id A0C3537B405
	for <current@FreeBSD.org>; Thu, 29 Nov 2001 23:39:51 -0800 (PST)
Received: from winston.freebsd.org (jkh@localhost [127.0.0.1])
	by winston.freebsd.org (8.11.6/8.11.6) with ESMTP id fAU7dhP09460;
	Thu, 29 Nov 2001 23:39:44 -0800 (PST)
	(envelope-from jkh@winston.freebsd.org)
To: Makoto Matsushita <matusita@jp.freebsd.org>
Cc: current@FreeBSD.org
Subject: Re: PATCH: sysinstall to remove userconfig code 
In-Reply-To: Message from Makoto Matsushita <matusita@jp.freebsd.org> 
   of "Fri, 30 Nov 2001 14:19:14 +0900." <20011130141914A.matusita@jp.FreeBSD.org> 
Date: Thu, 29 Nov 2001 23:39:43 -0800
Message-ID: <9456.1007105983@winston.freebsd.org>
From: Jordan Hubbard <jkh@winston.freebsd.org>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

> BTW, how dou you think my other patch (use 'devfs' while mounting
> filesystems, use fsck_ffs instead of fsck) for sysinstall, which was
> posted about a week before to current@FreeBSD.org?  You can fetch from:
> 
> <URL:http://people.freebsd.org/~matusita/5.0-CURRENT-20011121-JPSNAP_usedevfs
/patch>

Hmmm.  To be honest, at least one part doesn't make too much sense to
me.

In the quoted section, where you move up the code for copying the
initial /dev files from the mfsroot to the new on-disk root, you then
proceed to mount a devfs instance right over it.  Don't you want to
try the devfs mount and only copy device files if that returns an
error code?  You're just going to do extra work and then cover it up
otherwise. :-)


+ 
+       dialog_clear_norefresh();
+       msgNotify("Copying initial device files..");
+       /* Copy the boot floppy's dev files */
+       if ((root->newfs || upgrade) && vsystem("find -x /dev | cpio %s -pdum /mnt", cpioVerbosity())) {
+           msgConfirm("Couldn't clone the /dev files!");
+           return DITEM_FAILURE | DITEM_RESTORE;
+       }
+ 
+       /* Mount devfs for other partitions to mount */
+       Mkdir("/mnt/dev");
+       if (!Fake)
+           mount("devfs", "/mnt/dev", 0, NULL);
      }

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message