From owner-cvs-ports@FreeBSD.ORG Thu Feb 3 19:06:42 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28D30106566C for ; Thu, 3 Feb 2011 19:06:42 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id AC9F88FC0C for ; Thu, 3 Feb 2011 19:06:41 +0000 (UTC) Received: (qmail 26739 invoked by uid 399); 3 Feb 2011 19:06:41 -0000 Received: from localhost (HELO doug-optiplex.ka9q.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 3 Feb 2011 19:06:41 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4D4AFCBF.9030902@FreeBSD.org> Date: Thu, 03 Feb 2011 11:06:39 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20110129 Thunderbird/3.1.7 MIME-Version: 1.0 To: Tilman Keskinoz References: <201102031359.p13DxBEQ002135@repoman.freebsd.org> In-Reply-To: <201102031359.p13DxBEQ002135@repoman.freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, n_hibma@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/bincimap Makefile ports/mail/bincimap/files bincimapd.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Feb 2011 19:06:42 -0000 Overall the rc.d script looks good. 2 things, it needs a $FreeBSD$ (this can just be added without bumping anything) and it's not clear to me why the stop method is necessary. Doug On 02/03/2011 05:59, Tilman Keskinoz wrote: > arved 2011-02-03 13:59:11 UTC > > FreeBSD ports repository > > Modified files: > mail/bincimap Makefile > Added files: > mail/bincimap/files bincimapd.in > Log: > Add missing dependencies and an rc.d file > > PR: 127087 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=127087 > Submitted by: n_hibma > Feature safe: yes > > Revision Changes Path > 1.17 +5 -0 ports/mail/bincimap/Makefile > 1.1 +41 -0 ports/mail/bincimap/files/bincimapd.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/bincimap/Makefile.diff?&r1=1.16&r2=1.17&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/bincimap/files/bincimapd.in > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/