From owner-freebsd-stable@FreeBSD.ORG Sun Mar 31 05:20:11 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 56989CE6; Sun, 31 Mar 2013 05:20:11 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) by mx1.freebsd.org (Postfix) with ESMTP id BCD44A32; Sun, 31 Mar 2013 05:20:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id r2V5Duap039581; Sun, 31 Mar 2013 16:13:57 +1100 (EST) (envelope-from smithi@nimnet.asn.au) Date: Sun, 31 Mar 2013 16:13:56 +1100 (EST) From: Ian Smith To: Peter Wemm Subject: Re: Any objections/comments on axing out old ATA stack? In-Reply-To: Message-ID: <20130331160157.G36471@sola.nimnet.asn.au> References: <51536306.5030907@FreeBSD.org> <5157756F.4040908@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Alexander Motin , freebsd-stable@freebsd.org, Matthias Andree X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Mar 2013 05:20:11 -0000 On Sat, 30 Mar 2013 21:00:24 -0700, Peter Wemm wrote: > On Sat, Mar 30, 2013 at 4:29 PM, Matthias Andree wrote: > > Am 27.03.2013 22:22, schrieb Alexander Motin: > >> Hi. > >> > >> Since FreeBSD 9.0 we are successfully running on the new CAM-based ATA > >> stack, using only some controller drivers of old ata(4) by having > >> `options ATA_CAM` enabled in all kernels by default. I have a wish to > >> drop non-ATA_CAM ata(4) code, unused since that time from the head > >> branch to allow further ATA code cleanup. > >> > >> Does any one here still uses legacy ATA stack (kernel explicitly built > >> without `options ATA_CAM`) for some reason, for example as workaround > >> for some regression? Does anybody have good ideas why we should not drop > >> it now? > > > > Alexander, > > > > The regression in http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/157397 > > where the SATA NCQ slots stall for some Samsung drives in the new stack, > > and consequently hang the computer for prolonged episodes where it is in > > the NCQ error handling, disallows removal of the old driver. (Last > > checked with 9.1-RELEASE at current patchlevel.) > > We're talking about 10.x, so if you want it fixed, you need update > with 10.x information. > > Please put 10.x diagnostics in the PR. Given Alexander also posted this to -stable, just for clarity, are we _only_ talking about 10.x here, or might this change get MFC'd to 9? cheers, Ian (dropping -current as I'm not subscribed so would only get bounced)