Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Jul 2014 10:35:26 +0200
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        marino@freebsd.org, Max Brazhnikov <makc@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, William Grzybowski <wg@freebsd.org>, Adam Weinberger <adamw@adamw.org>
Subject:   Re: svn commit: r363361 - in head/editors/fte: . files
Message-ID:  <79ADB965FF3B933E075F07BD@atuin.in.mat.cc>
In-Reply-To: <53D8A930.3020806@marino.st>
References:  <201407291646.s6TGkjHH090335@svn.freebsd.org> <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org> <20140730070412.GA97692@FreeBSD.org> <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st> <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc> <53D8A930.3020806@marino.st>

next in thread | previous in thread | raw e-mail | index | archive | help


+--On 30 juillet 2014 10:13:36 +0200 John Marino
<freebsd.contact@marino.st> wrote:
| On 7/30/2014 10:08, Mathieu Arnold wrote:
|> 
|> 
|> +--On 30 juillet 2014 09:46:03 +0200 John Marino
|> <freebsd.contact@marino.st> wrote:
|> | Take a vote. I'd bet the majority of people do not like "__" not just
|> | "someone".
|> 
|> But, I think you're missing the point, who cares what the separator is ?
| 
| All the people that don't use makepatch because it makes stupid patch
| names care (or any other reason they don't use makepatch).

You mean there are people that are actually not using make makepatch ? WTF
? No wonder patch sometime do not apply cleanly...

| We obviously care.  I care enough that I'm considering going through the
| bureaucratic hassle of getting a patch name convention outlined in
| documentation thus forcing a change to tools like makepatch.  Danfe@
| obviously cares enough about his eyesight to want it changed.

You're also missing the point where it is already documented.

It is so strange that in open source projects people can argue at no end
about pointless things that do not matter.


Now, to make it clear, we have a convention, when you're done patching a
software, you go to the ports directory, and you run make makepatch, it
generates a set of files that you will add and commit without changing
their names so that then next guy around can also run make makepatch and
not have to figure out why the files were originally not named the right
way.


-- 
Mathieu Arnold



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?79ADB965FF3B933E075F07BD>