Date: Tue, 6 Nov 2007 17:37:37 -0800 From: "Jack Vogel" <jfvogel@gmail.com> To: "Jack F Vogel" <jfv@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Message-ID: <2a41acea0711061737y188c09a4ob0f6ce8f58ad0ea8@mail.gmail.com> In-Reply-To: <200711070133.lA71XTIn068238@repoman.freebsd.org> References: <200711070133.lA71XTIn068238@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/6/07, Jack F Vogel <jfv@freebsd.org> wrote: > jfv 2007-11-07 01:33:29 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/dev/em if_em.c if_em.h > Log: > This delta addresses some users experiencing watchdogs under load with > the last driver version. I suspect sheduling to be at the bottom of it, > but this version fixes it by: > - Making FAST interrupt handling off by default, if you want > to use it #define EM_FAST_IRQ in the Makefile. > - Add dual locks, one for the TX subsystem, the other CORE > for things like init and interface managment. > - Add cleaner MSI/X setup code. > - If using FAST interrupts there is now a mechanism in the > watchdog routine to kick off TX cleanups if they have not > been scheduled. > > I think everyone will be happier with this change. > > Revision Changes Path > 1.65.2.28 +327 -144 src/sys/dev/em/if_em.c > 1.32.2.8 +16 -10 src/sys/dev/em/if_em.h > I should add that Mike Silbersack was responsible for the workaround method used in the watchdog. Both Mike and Scott Long were helpful in debugging and discussions solutions. Thanks guys. I made this change now so that it gets some testing and we work out any issues before 6.3. Cheers, Jack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2a41acea0711061737y188c09a4ob0f6ce8f58ad0ea8>