From owner-svn-src-projects@FreeBSD.ORG Sat Aug 7 17:39:23 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E33CC106566C; Sat, 7 Aug 2010 17:39:22 +0000 (UTC) (envelope-from attilio@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id D25778FC14; Sat, 7 Aug 2010 17:39:22 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o77HdMow009459; Sat, 7 Aug 2010 17:39:22 GMT (envelope-from attilio@svn.freebsd.org) Received: (from attilio@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o77HdM2Y009458; Sat, 7 Aug 2010 17:39:22 GMT (envelope-from attilio@svn.freebsd.org) Message-Id: <201008071739.o77HdM2Y009458@svn.freebsd.org> From: Attilio Rao Date: Sat, 7 Aug 2010 17:39:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r211029 - projects/sv/sys/net X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Aug 2010 17:39:23 -0000 Author: attilio Date: Sat Aug 7 17:39:22 2010 New Revision: 211029 URL: http://svn.freebsd.org/changeset/base/211029 Log: Add a tunable for nd_enable. As long as TUNABLE_INT is discouraged, however, switch the type int -> long and adjust accordingly the sysctl stubs. Modified: projects/sv/sys/net/netdump_client.c Modified: projects/sv/sys/net/netdump_client.c ============================================================================== --- projects/sv/sys/net/netdump_client.c Sat Aug 7 17:30:15 2010 (r211028) +++ projects/sv/sys/net/netdump_client.c Sat Aug 7 17:39:22 2010 (r211029) @@ -162,7 +162,7 @@ static unsigned char buf[MAXDUMPPGS*PAGE * us */ static struct ether_addr nd_server_mac; -static int nd_enable = 0; /* if we should perform a network dump */ +static long nd_enable = 0; /* if we should perform a network dump */ static struct in_addr nd_server = {INADDR_ANY}; /* server address */ static struct in_addr nd_client = {INADDR_ANY}; /* client (our) address */ struct ifnet *nd_nic = NULL; @@ -331,8 +331,6 @@ sysctl_force_crash(SYSCTL_HANDLER_ARGS) } SYSCTL_NODE(_net, OID_AUTO, dump, CTLFLAG_RW, 0, "netdump"); -SYSCTL_INT(_net_dump, OID_AUTO, enable, CTLTYPE_INT|CTLFLAG_RW, &nd_enable, 0, - "enable network dump"); SYSCTL_PROC(_net_dump, OID_AUTO, server, CTLTYPE_STRING|CTLFLAG_RW, &nd_server, 0, sysctl_ip, "A", "dump server"); SYSCTL_PROC(_net_dump, OID_AUTO, client, CTLTYPE_STRING|CTLFLAG_RW, &nd_client, @@ -345,6 +343,9 @@ SYSCTL_INT(_net_dump, OID_AUTO, polls, C "times to poll NIC per retry"); SYSCTL_INT(_net_dump, OID_AUTO, retries, CTLTYPE_INT|CTLFLAG_RW, &nd_retries, 0, "times to retransmit lost packets"); +SYSCTL_LONG(_net_dump, OID_AUTO, enable, CTLTYPE_LONG|CTLFLAG_RW, &nd_enable, + 0, "enable network dump"); +TUNABLE_LONG("net.dump.enable", &nd_enable); /*- * Network specific primitives.