From owner-freebsd-ports@FreeBSD.ORG Fri Jul 9 13:46:05 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3F4A106566C; Fri, 9 Jul 2010 13:46:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 96A5E8FC18; Fri, 9 Jul 2010 13:46:05 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 48E1746C08; Fri, 9 Jul 2010 09:46:05 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 71A9E8A051; Fri, 9 Jul 2010 09:46:04 -0400 (EDT) From: John Baldwin To: Doug Barton Date: Fri, 9 Jul 2010 08:27:09 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100217; KDE/4.4.5; amd64; ; ) References: <201007081750.00871.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007090827.09471.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 09 Jul 2010 09:46:04 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: ports@freebsd.org Subject: Re: Review request for new port: sysutils/etcupdate X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jul 2010 13:46:05 -0000 On Thursday, July 08, 2010 6:12:39 pm Doug Barton wrote: > On Thu, 8 Jul 2010, John Baldwin wrote: > > > This is a port for yet-another-/etc-merging tool that I wrote recently. It > > passes portlint -N with one bogus warning because /etc is in the comment. > > I didn't try installing/deinstalling but you seem to have the right > stuff in the Makefile for that. Overall it looks good, just a couple > comments: > 1. I don't think textproc is right for CATEGORIES, although sysutils is > of course. > 2. I don't think the do-fetch target is necessary, but if it is needed > when you test it that's fine. > 3. You have a pkg-descr~ file in the shar that should be deleted before > you commit it. > > Assuming it passes all the tests in the porter's handbook for install, > deinstall, package, etc. I'd say go ahead. :) Ok. Should I fix 1) and 2) for the sysutils/etcmerge port as well? (I used etcmerge as a template.) -- John Baldwin