From owner-freebsd-bugs@FreeBSD.ORG Mon Oct 16 01:21:01 2006 Return-Path: X-Original-To: freebsd-bugs@FreeBSD.org Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7FC816A403; Mon, 16 Oct 2006 01:21:01 +0000 (UTC) (envelope-from clsung@FreeBSD.csie.nctu.edu.tw) Received: from FreeBSD.csie.nctu.edu.tw (freebsd.csie.nctu.edu.tw [140.113.17.209]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2EED643D4C; Mon, 16 Oct 2006 01:21:00 +0000 (GMT) (envelope-from clsung@FreeBSD.csie.nctu.edu.tw) Received: from localhost (localhost.csie.nctu.edu.tw [127.0.0.1]) by FreeBSD.csie.nctu.edu.tw (Postfix) with ESMTP id 48D7F7E9C6; Mon, 16 Oct 2006 09:21:32 +0800 (CST) Received: from FreeBSD.csie.nctu.edu.tw ([127.0.0.1]) by localhost (FreeBSD.csie.nctu.edu.tw [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mfri3moTYYQS; Mon, 16 Oct 2006 09:21:31 +0800 (CST) Received: by FreeBSD.csie.nctu.edu.tw (Postfix, from userid 1038) id 9D2987E9C7; Mon, 16 Oct 2006 09:21:31 +0800 (CST) Date: Mon, 16 Oct 2006 09:21:31 +0800 From: Cheng-Lung Sung To: Bruce Evans Message-ID: <20061016012131.GA22894@FreeBSD.csie.nctu.edu.tw> References: <20061015135710.A28897E98D@FreeBSD.csie.nctu.edu.tw> <20061016011559.W61639@delplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: <20061016011559.W61639@delplex.bde.org> X-Fingerprint: E0BC 57F9 F44B 46C6 DB53 8462 F807 89F3 956E 8BC1 X-Public-Key: http://sungsung.dragon2.net/pubring.asc User-Agent: Mutt/1.5.13 (2006-08-11) Cc: freebsd-current@FreeBSD.org, freebsd-bugs@FreeBSD.org, Cheng-Lung Sung , FreeBSD-gnats-submit@FreeBSD.org, freebsd-hackers@FreeBSD.org Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2006 01:21:01 -0000 --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=big5 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 16, 2006 at 01:21:59AM +1000, Bruce Evans wrote: > On Sun, 15 Oct 2006, Cheng-Lung Sung wrote: >=20 > >System: FreeBSD.csie.nctu.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #9: Thu M= ay=20 > >11 14:31:45 CST 2006 =20 > >root@FreeBSD.csie.nctu.edu.tw:/home/usr.obj/usr/src/sys/FREEBSD i386 > > > >>Description: > >- sys/sem.h has included sys/ipc.h, which includes sys/_types.h > > but it (and its including files) does not include sys/types.h > >- therefore, in sys/sem.h struct semid_ds declares "time_t sem_otime;"= =20 > >...etc > >- if we only compile a program which do not include sys/types.h, it will= =20 > >fail. >=20 > Including sys/types.h would add lots of namespace pollution which > sys/ipc.h and sys/sem.h are trying hard to avoid. sem.h is trying too > hard -- POSIX requires it to declare time_t (and pid_t, key_t and size_t, > which it already declares). >=20 > Bruce You're right, I should try to pass COMMON_HEADERS to ruby-sysipc=20 instead of polluting namespace. Thanks, --=20 Cheng-Lung Sung - clsung@ --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFMt6a+AeJ85Vui8ERAkpiAKCT0qnMLSJa1lUsjqBA7XOpvkKeQgCfc0sn r/6xcrfx71DYTCstiZC8GPA= =P6zp -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--