Date: Mon, 14 Oct 2002 16:15:12 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: net@FreeBSD.org Subject: Rename of MSIZE kernel option.. Message-ID: <XFMail.20021014161512.jhb@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
Would people be open to renaming the 'MSIZE' kernel option to something more specific such as 'MBUF_SIZE' or 'MBUFSIZE'? Using 'MSIZE' can break other places in the kernel. For example, ISA device ivars have an ivar for the size of a memory resource called 'MSIZE' and the kernel option causes breakage in src/sys/isa/isavar.h: ISA_ACCESSOR(msize, MSIZE, int) when ISA_ACCESSOR is properly defined via __BUS_ACCESSOR() rather than homerolling a private copy of __BUS_ACCESSOR(). For now I've fixed it to rename the ISA ivar to ISA_IVAR_MEMSIZE but MSIZE seems to be too generic a name for a kernel option and it would be nice to avoid this problem in the future. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021014161512.jhb>