From owner-cvs-src@FreeBSD.ORG  Wed Apr 16 07:23:45 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E682B37B401; Wed, 16 Apr 2003 07:23:45 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DF7BC43FA3; Wed, 16 Apr 2003 07:23:43 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id AAA27215;
	Thu, 17 Apr 2003 00:23:36 +1000
Date: Thu, 17 Apr 2003 00:23:35 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Bruce Evans <bde@FreeBSD.org>
In-Reply-To: <200304161350.h3GDorNU058617@repoman.freebsd.org>
Message-ID: <20030417000737.J6033@gamplex.bde.org>
References: <200304161350.h3GDorNU058617@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/named Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Apr 2003 14:23:46 -0000

On Wed, 16 Apr 2003, Bruce Evans wrote:

> bde         2003/04/16 06:50:53 PDT
>
>   FreeBSD src repository
>
>   Modified files:
>     usr.sbin/named       Makefile
>   Log:
>   "Fixed" LDADD by backing out part of the previous commit.  -lfoo in
>   LDADD is not wrong, but the simple substitution in `make checkdpadd'
>   doesn't work if foo.a is not an installed library, so we use the full
>   path to foo.a in both DPADD and LDADD for non-installed libraries.
>
>   Revision  Changes    Path
>   1.35      +1 -1      src/usr.sbin/named/Makefile

Actually -lfoo was wrong here, since there is no -L to tell the linker
where the non-installed library is.  It worked accidentally because
libisc is actually installed and changing to using the dynamic libisc
didn't cause problems.  Using the installed library is probably right,
but it is not what the bind utilities expect -- all their (FreeBSD)
makefiles that use libisc (only named and named-xfer) have 7 lines of
code to use the non-installed one.  The broken part of the previous
commit reduced these lines to just breaking DPADD and this commit just
makes them a verbose way of doing things again.

The a.out linker had support for determining the libraries that will
be used less hackishly, but using the full path to the (static) library
in both DPADD and LDADD for non-installed libraries was still necessary
to handle the case where the libraries don't exist at `make depend' time.

Bruce